Commit 274e43ed authored Oct 12, 2016 by Azhar Shaikh Committed by Lee Jones Nov 16, 2016

mfd: intel-lpss: Do not put device in reset state on suspend



Commit 41a3da2b ("mfd: intel-lpss: Save register context on
suspend") saved the register context while going to suspend and
also put the device in reset state.

Due to the resetting of device, system cannot enter S3/S0ix
states when no_console_suspend flag is enabled. The system
and serial console both hang. The resetting of device is not
needed while going to suspend. Hence remove this code.

Cc: stable@vger.kernel.org
Fixes: 41a3da2b ("mfd: intel-lpss: Save register context on suspend")
Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

parent 2c8c3416

drivers/mfd/intel-lpss.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -502,9 +502,6 @@ int intel_lpss_suspend(struct device *dev)
		for (i = 0; i < LPSS_PRIV_REG_COUNT; i++)
		lpss->priv_ctx[i] = readl(lpss->priv + i * 4);

		/* Put the device into reset state */
		writel(0, lpss->priv + LPSS_PRIV_RESETS);

		return 0;
		}
		EXPORT_SYMBOL_GPL(intel_lpss_suspend);

Admin message