Commit 27429be7 authored Jul 08, 2019 by Jacob Keller Committed by Jeff Kirsher Aug 04, 2019

fm10k: cast page_addr to u8 * when incrementing it



The page_addr variable is a void pointer. Incrementing it before calling
prefetch is technically undefined. Fix this by casting it to a u8*
pointer before incrementing it. This ensures that we increment the
pointer value in byte units, instead of relying on this undefined
behavior.

This was detected by cppcheck, and resolves the following warning
produced by that tool:

[fm10k_main.c:328]: (portability) 'page_addr' is of type 'void *'. When
using void pointers in calculations, the behaviour is undefined.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 9aac0fbd

drivers/net/ethernet/intel/fm10k/fm10k_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -315,7 +315,7 @@ static struct sk_buff fm10k_fetch_rx_buffer(struct fm10k_ring rx_ring,
		/* prefetch first cache line of first page */
		prefetch(page_addr);
		#if L1_CACHE_BYTES < 128
		prefetch(page_addr + L1_CACHE_BYTES);
		prefetch((void )((u8 )page_addr + L1_CACHE_BYTES));
		#endif

		/* allocate a skb to store the frags */

Admin message