Commit 271a9c35 authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

uprobes: Remove "weak" from function declarations 



For the following interfaces:

  set_swbp()
  set_orig_insn()
  is_swbp_insn()
  is_trap_insn()
  uprobe_get_swbp_addr()
  arch_uprobe_ignore()
  arch_uprobe_copy_ixol()

kernel/events/uprobes.c provides default definitions explicitly marked
"weak".  Some architectures provide their own definitions intended to
override the defaults, but the "weak" attribute on the declarations applied
to the arch definitions as well, so the linker chose one based on link
order (see 10629d71 ("PCI: Remove __weak annotation from
pcibios_get_phb_of_node decl")).

Remove the "weak" attribute from the declarations so we always prefer a
non-weak definition over the weak one, independent of link order.

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarIngo Molnar <mingo@kernel.org>
Acked-by: default avatarSrikar Dronamraju <srikar@linux.vnet.ibm.com>
CC: Victor Kamensky <victor.kamensky@linaro.org>
CC: Oleg Nesterov <oleg@redhat.com>
CC: David A. Long <dave.long@linaro.org>
CC: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
parent e0a8400c

include/linux/uprobes.h

+7 −7
Original line number Diff line number Diff line
@@ -98,11 +98,11 @@ struct uprobes_state { 
	struct xol_area		*xol_area;

};



extern int __weak set_swbp(struct arch_uprobe *aup, struct mm_struct *mm, unsigned long vaddr);

extern int __weak set_orig_insn(struct arch_uprobe *aup, struct mm_struct *mm, unsigned long vaddr);

extern bool __weak is_swbp_insn(uprobe_opcode_t *insn);

extern bool __weak is_trap_insn(uprobe_opcode_t *insn);

extern unsigned long __weak uprobe_get_swbp_addr(struct pt_regs *regs);

extern int set_swbp(struct arch_uprobe *aup, struct mm_struct *mm, unsigned long vaddr);

extern int set_orig_insn(struct arch_uprobe *aup, struct mm_struct *mm, unsigned long vaddr);

extern bool is_swbp_insn(uprobe_opcode_t *insn);

extern bool is_trap_insn(uprobe_opcode_t *insn);

extern unsigned long uprobe_get_swbp_addr(struct pt_regs *regs);

extern unsigned long uprobe_get_trap_addr(struct pt_regs *regs);

extern int uprobe_write_opcode(struct mm_struct *mm, unsigned long vaddr, uprobe_opcode_t);

extern int uprobe_register(struct inode *inode, loff_t offset, struct uprobe_consumer *uc);
@@ -128,8 +128,8 @@ extern bool arch_uprobe_xol_was_trapped(struct task_struct *tsk); 
extern int  arch_uprobe_exception_notify(struct notifier_block *self, unsigned long val, void *data);

extern void arch_uprobe_abort_xol(struct arch_uprobe *aup, struct pt_regs *regs);

extern unsigned long arch_uretprobe_hijack_return_addr(unsigned long trampoline_vaddr, struct pt_regs *regs);

extern bool __weak arch_uprobe_ignore(struct arch_uprobe *aup, struct pt_regs *regs);

extern void __weak arch_uprobe_copy_ixol(struct page *page, unsigned long vaddr,

extern bool arch_uprobe_ignore(struct arch_uprobe *aup, struct pt_regs *regs);

extern void arch_uprobe_copy_ixol(struct page *page, unsigned long vaddr,

					 void *src, unsigned long len);

#else /* !CONFIG_UPROBES */

struct uprobes_state {

CRA Git | Maintained and supported by SUSTech CRA and CCSE