Commit 27163138 authored Aug 24, 2017 by Parthasarathy Bhuvaragan Committed by David S. Miller Aug 24, 2017

tipc: perform skb_linearize() before parsing the inner header



In tipc_rcv(), we linearize only the header and usually the packets
are consumed as the nodes permit direct reception. However, if the
skb contains tunnelled message due to fail over or synchronization
we parse it in tipc_node_check_state() without performing
linearization. This will cause link disturbances if the skb was
non linear.

In this commit, we perform linearization for the above messages.

Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@ericsson.com>
Reviewed-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 551143d8

net/tipc/node.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1557,6 +1557,8 @@ void tipc_rcv(struct net net, struct sk_buff skb, struct tipc_bearer *b)

		/* Check/update node state before receiving */
		if (unlikely(skb)) {
		if (unlikely(skb_linearize(skb)))
		goto discard;
		tipc_node_write_lock(n);
		if (tipc_node_check_state(n, skb, bearer_id, &xmitq)) {
		if (le->link) {

Admin message