Commit 26fbb774 authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Daniel Vetter
Browse files

drm/i915: Make hpd debug messages less cryptic 



Don't print raw numbers, use port_name() and tell the user whether it's
long or short without having to figure out what the other magic number
means.

Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: default avatarDamien Lespiau <damien.lespiau@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent e94e37ad

drivers/gpu/drm/i915/i915_irq.c

+3 −1
Original line number Diff line number Diff line
@@ -1777,7 +1777,9 @@ static inline void intel_hpd_irq_handler(struct drm_device *dev, 
				long_hpd = (dig_hotplug_reg >> dig_shift) & PORTB_HOTPLUG_LONG_DETECT;

			}



			DRM_DEBUG_DRIVER("digital hpd port %d %d\n", port, long_hpd);

			DRM_DEBUG_DRIVER("digital hpd port %c - %s\n",

					 port_name(port),

					 long_hpd ? "long" : "short");

			/* for long HPD pulses we want to have the digital queue happen,

			   but we still want HPD storm detection to function. */

			if (long_hpd) {

drivers/gpu/drm/i915/intel_dp.c

+2 −1
Original line number Diff line number Diff line
@@ -4041,7 +4041,8 @@ intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd) 
	if (intel_dig_port->base.type != INTEL_OUTPUT_EDP)

		intel_dig_port->base.type = INTEL_OUTPUT_DISPLAYPORT;



	DRM_DEBUG_KMS("got hpd irq on port %d - %s\n", intel_dig_port->port,

	DRM_DEBUG_KMS("got hpd irq on port %c - %s\n",

		      port_name(intel_dig_port->port),

		      long_hpd ? "long" : "short");



	if (long_hpd) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE