Commit 26e2fa76 authored May 19, 2014 by Julia Lawall Committed by Greg Kroah-Hartman May 24, 2014

staging: rtl8192e: make return of 0 explicit

Delete unnecessary use of a local variable to immediately return 0.

A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@r exists@
local idexpression ret;
expression e;
position p;
@@

-ret = 0;
... when != ret = e
return
- ret
+ 0
  ;
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9cdf838b

drivers/staging/rtl8192e/rtl8192e/rtl_core.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1915,8 +1915,7 @@ int rtl8192_hard_start_xmit(struct sk_buff skb, struct net_device dev)
		memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
		if (queue_index == TXCMD_QUEUE) {
		rtl8192_tx_cmd(dev, skb);
		ret = 0;
		return ret;
		return 0;
		} else {
		tcb_desc->RATRIndex = 7;
		tcb_desc->bTxDisableRateFallBack = 1;

Admin message