Commit 26d5a324 authored Jun 12, 2019 by Nava kishore Manne Committed by Greg Kroah-Hartman Jun 18, 2019

serial: uartps: Use octal permission for module_param()



Octal permission is preffered compare to symbolic one.

This patch fixes checkpatch warnings:
Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal
permissions '0444'.

Fixes: 85baf542 ("tty: xuartps: support 64 byte FIFO size")
Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent ab262666

drivers/tty/serial/xilinx_uartps.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -37,12 +37,12 @@
		/* Rx Trigger level */
		static int rx_trigger_level = 56;
		static int uartps_major;
		module_param(rx_trigger_level, uint, S_IRUGO);
		module_param(rx_trigger_level, uint, 0444);
		MODULE_PARM_DESC(rx_trigger_level, "Rx trigger level, 1-63 bytes");

		/* Rx Timeout */
		static int rx_timeout = 10;
		module_param(rx_timeout, uint, S_IRUGO);
		module_param(rx_timeout, uint, 0444);
		MODULE_PARM_DESC(rx_timeout, "Rx timeout, 1-255");

		/* Register offsets for the UART. */

Admin message