Commit 26b8f996 authored by Vineet Gupta's avatar Vineet Gupta
Browse files

ARCv2: smp: [plat-*]: No need to explicitly call mcip_init_early_smp() 



MCIP now registers it's own probe callback with smp_ops.init_early_smp()
which is called by ARC common code, so no need for platforms to do that.

This decouples the platforms and MCIP and helps confine MCIP details
to it's own file.

Signed-off-by: default avatarVineet Gupta <vgupta@synopsys.com>
parent e55af4da

arch/arc/include/asm/mcip.h

+0 −1
Original line number Diff line number Diff line
@@ -86,7 +86,6 @@ static inline void __mcip_cmd_data(unsigned int cmd, unsigned int param, 
	__mcip_cmd(cmd, param);

}



extern void mcip_init_early_smp(void);

extern void mcip_init_smp(unsigned int cpu);



#endif

arch/arc/kernel/mcip.c

+8 −7
Original line number Diff line number Diff line
@@ -97,13 +97,7 @@ static void mcip_ipi_clear(int irq) 
#endif

}



struct plat_smp_ops plat_smp_ops = {

	.info		= smp_cpuinfo_buf,

	.ipi_send	= mcip_ipi_send,

	.ipi_clear	= mcip_ipi_clear,

};



void mcip_init_early_smp(void)

static void mcip_probe_n_setup(void)

{

	struct mcip_bcr {

#ifdef CONFIG_CPU_BIG_ENDIAN
@@ -142,6 +136,13 @@ void mcip_init_early_smp(void) 
		panic("kernel trying to use non-existent GRTC\n");

}



struct plat_smp_ops plat_smp_ops = {

	.info		= smp_cpuinfo_buf,

	.init_early_smp	= mcip_probe_n_setup,

	.ipi_send	= mcip_ipi_send,

	.ipi_clear	= mcip_ipi_clear,

};



/***************************************************************************

 * ARCv2 Interrupt Distribution Unit (IDU)

 *

arch/arc/plat-axs10x/axs10x.c

+0 −5
Original line number Diff line number Diff line
@@ -455,11 +455,6 @@ static void __init axs103_early_init(void) 
	axs10x_print_board_ver(AXC003_CREG + 4088, "AXC003 CPU Card");



	axs10x_early_init();



#ifdef CONFIG_ARC_MCIP

	/* No Hardware init, but filling the smp ops callbacks */

	mcip_init_early_smp();

#endif

}

#endif

arch/arc/plat-sim/platform.c

+0 −1
Original line number Diff line number Diff line
@@ -31,7 +31,6 @@ static const char *simulation_compat[] __initconst = { 
MACHINE_START(SIMULATION, "simulation")

	.dt_compat	= simulation_compat,

#ifdef CONFIG_ARC_MCIP

	.init_early	= mcip_init_early_smp,

	.init_smp	= mcip_init_smp,

#endif

MACHINE_END

CRA Git | Maintained and supported by SUSTech CRA and CCSE