Commit 26b284de authored Aug 13, 2008 by Jarek Poplawski Committed by David S. Miller Aug 13, 2008

pkt_sched: Fix oops in htb_delete.



Recent changes introduced a bug in htb_delete(): cl->parent->children
counter update misses checking cl->parent for NULL, which is used for
root classes, so deleting them causes an oops.

Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 64c00d81

net/sched/sch_htb.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1279,6 +1279,7 @@ static int htb_delete(struct Qdisc *sch, unsigned long arg)

		/* delete from hash and active; remainder in destroy_class */
		qdisc_class_hash_remove(&q->clhash, &cl->common);
		if (cl->parent)
		cl->parent->children--;

		if (cl->prio_activity)

Admin message