netfilter: bitwise: remove NULL comparisons from attribute checks. (265ec7b0) · Commits · 戴 / test

In later patches, we will be adding more checks. In order to be consistent and prevent complaints from checkpatch.pl, replace the existing comparisons with NULL with logical NOT operators. Signed-off-by:

Jeremy Sowden <jeremy@azazel.net> Signed-off-by:

Pablo Neira Ayuso <pablo@netfilter.org>

net/netfilter/nft_bitwise.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -52,11 +52,11 @@ static int nft_bitwise_init(const struct nft_ctx *ctx,
		u32 len;
		int err;

		if (tb[NFTA_BITWISE_SREG] == NULL \|\|
		tb[NFTA_BITWISE_DREG] == NULL \|\|
		tb[NFTA_BITWISE_LEN] == NULL \|\|
		tb[NFTA_BITWISE_MASK] == NULL \|\|
		tb[NFTA_BITWISE_XOR] == NULL)
		if (!tb[NFTA_BITWISE_SREG] \|\|
		!tb[NFTA_BITWISE_DREG] \|\|
		!tb[NFTA_BITWISE_LEN] \|\|
		!tb[NFTA_BITWISE_MASK] \|\|
		!tb[NFTA_BITWISE_XOR])
		return -EINVAL;

		err = nft_parse_u32_check(tb[NFTA_BITWISE_LEN], U8_MAX, &len);

Admin message