Commit 2652c216 authored Jul 19, 2013 by Dan Carpenter Committed by Greg Kroah-Hartman Jul 24, 2013

TTY: snyclinkmp: calculating wrong addresses

This is a static checker fix and I don't have a way to test it. But
from the context it looks like this is a typo where SCABUFSIZE was
intended instead of sizeof(SCABUFSIZE). SCABUFSIZE is 1024 and
sizeof(int) is 4. I would suspect this is a bad bug.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 3b2f64d0

drivers/tty/synclinkmp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3478,7 +3478,7 @@ static int alloc_buf_list(SLMP_INFO *info)
		for ( i = 0; i < info->rx_buf_count; i++ ) {
		/* calculate and store physical address of this buffer entry */
		info->rx_buf_list_ex[i].phys_entry =
		info->buffer_list_phys + (i * sizeof(SCABUFSIZE));
		info->buffer_list_phys + (i * SCABUFSIZE);

		/* calculate and store physical address of */
		/* next entry in cirular list of entries */

Admin message