Commit 264f7b8a authored by David Binder's avatar David Binder Committed by Greg Kroah-Hartman
Browse files

staging: unisys: visorbus: Convert visorchannel_signalinsert() return val 



Per Documentation/CodingStyle, function names that convey an action or an
imperative command should return an integer. This commit converts the
visorbus API function, visorchannel_signalinsert(), to returning integer
values. All uses of this function are updated accordingly.

Signed-off-by: default avatarDavid Binder <david.binder@unisys.com>
Signed-off-by: default avatarDavid Kershner <david.kershner@unisys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f621a968

drivers/staging/unisys/include/visorbus.h

+2 −2
Original line number Diff line number Diff line
@@ -202,7 +202,7 @@ enum diag_severity { 


int visorchannel_signalremove(struct visorchannel *channel, u32 queue,

			      void *msg);

bool visorchannel_signalinsert(struct visorchannel *channel, u32 queue,

int visorchannel_signalinsert(struct visorchannel *channel, u32 queue,

			      void *msg);

bool visorchannel_signalempty(struct visorchannel *channel, u32 queue);

uuid_le visorchannel_get_uuid(struct visorchannel *channel);

drivers/staging/unisys/visorbus/visorchannel.c

+4 −4
Original line number Diff line number Diff line
@@ -493,12 +493,12 @@ visorchannel_create_with_lock(u64 physaddr, unsigned long channel_bytes, 
 * @queue:   the queue the message will be added to

 * @msg:     the message to insert

 *

 * Return: boolean indicating whether the insertion succeeded or failed

 * Return: integer error code indicating the status of the insertion

 */

bool

int

visorchannel_signalinsert(struct visorchannel *channel, u32 queue, void *msg)

{

	bool rc;

	int rc;

	unsigned long flags;



	if (channel->needs_lock) {
@@ -509,6 +509,6 @@ visorchannel_signalinsert(struct visorchannel *channel, u32 queue, void *msg) 
		rc = signalinsert_inner(channel, queue, msg);

	}



	return !rc;

	return rc;

}

EXPORT_SYMBOL_GPL(visorchannel_signalinsert);

drivers/staging/unisys/visorbus/visorchipset.c

+8 −8
Original line number Diff line number Diff line
@@ -508,7 +508,7 @@ controlvm_respond_chipset_init(struct controlvm_message_header *msg_hdr, 


	controlvm_init_response(&outmsg, msg_hdr, response);

	outmsg.cmd.init_chipset.features = features;

	if (!visorchannel_signalinsert(controlvm_channel,

	if (visorchannel_signalinsert(controlvm_channel,

				      CONTROLVM_QUEUE_REQUEST, &outmsg)) {

		return;

	}
@@ -557,7 +557,7 @@ controlvm_respond(struct controlvm_message_header *msg_hdr, int response) 
	if (outmsg.hdr.flags.test_message == 1)

		return;



	if (!visorchannel_signalinsert(controlvm_channel,

	if (visorchannel_signalinsert(controlvm_channel,

				      CONTROLVM_QUEUE_REQUEST, &outmsg)) {

		return;

	}
@@ -572,7 +572,7 @@ static void controlvm_respond_physdev_changestate( 
	controlvm_init_response(&outmsg, msg_hdr, response);

	outmsg.cmd.device_change_state.state = state;

	outmsg.cmd.device_change_state.flags.phys_device = 1;

	if (!visorchannel_signalinsert(controlvm_channel,

	if (visorchannel_signalinsert(controlvm_channel,

				      CONTROLVM_QUEUE_REQUEST, &outmsg)) {

		return;

	}
@@ -670,7 +670,7 @@ device_changestate_responder(enum controlvm_id cmd_id, 
	outmsg.cmd.device_change_state.dev_no = dev_no;

	outmsg.cmd.device_change_state.state = response_state;



	if (!visorchannel_signalinsert(controlvm_channel,

	if (visorchannel_signalinsert(controlvm_channel,

				      CONTROLVM_QUEUE_REQUEST, &outmsg))

		return;

}

drivers/staging/unisys/visorhba/visorhba_main.c

+6 −6
Original line number Diff line number Diff line
@@ -335,7 +335,7 @@ static int forward_taskmgmt_command(enum task_mgmt_types tasktype, 


	dev_dbg(&scsidev->sdev_gendev,

		"visorhba: initiating type=%d taskmgmt command\n", tasktype);

	if (!visorchannel_signalinsert(devdata->dev->visorchannel,

	if (visorchannel_signalinsert(devdata->dev->visorchannel,

				      IOCHAN_TO_IOPART,

				      cmdrsp))

		goto err_del_scsipending_ent;
@@ -538,7 +538,7 @@ visorhba_queue_command_lck(struct scsi_cmnd *scsicmd, 
	}

	cmdrsp->scsi.guest_phys_entries = scsi_sg_count(scsicmd);



	if (!visorchannel_signalinsert(devdata->dev->visorchannel,

	if (visorchannel_signalinsert(devdata->dev->visorchannel,

				      IOCHAN_TO_IOPART,

				      cmdrsp))

		/* queue must be full and we aren't going to wait */

drivers/staging/unisys/visornic/visornic_main.c

+8 −8
Original line number Diff line number Diff line
@@ -386,7 +386,7 @@ post_skb(struct uiscmdrsp *cmdrsp, 
	if ((cmdrsp->net.rcvpost.frag.pi_off + skb->len) <= PI_PAGE_SIZE) {

		cmdrsp->net.type = NET_RCV_POST;

		cmdrsp->cmdtype = CMD_NET_TYPE;

		if (visorchannel_signalinsert(devdata->dev->visorchannel,

		if (!visorchannel_signalinsert(devdata->dev->visorchannel,

					       IOCHAN_TO_IOPART,

					       cmdrsp)) {

			atomic_inc(&devdata->num_rcvbuf_in_iovm);
@@ -415,7 +415,7 @@ send_enbdis(struct net_device *netdev, int state, 
	devdata->cmdrsp_rcv->net.enbdis.context = netdev;

	devdata->cmdrsp_rcv->net.type = NET_RCV_ENBDIS;

	devdata->cmdrsp_rcv->cmdtype = CMD_NET_TYPE;

	if (visorchannel_signalinsert(devdata->dev->visorchannel,

	if (!visorchannel_signalinsert(devdata->dev->visorchannel,

				       IOCHAN_TO_IOPART,

				       devdata->cmdrsp_rcv))

		devdata->chstat.sent_enbdis++;
@@ -881,7 +881,7 @@ visornic_xmit(struct sk_buff *skb, struct net_device *netdev) 
		return NETDEV_TX_OK;

	}



	if (!visorchannel_signalinsert(devdata->dev->visorchannel,

	if (visorchannel_signalinsert(devdata->dev->visorchannel,

				      IOCHAN_TO_IOPART, cmdrsp)) {

		netif_stop_queue(netdev);

		spin_unlock_irqrestore(&devdata->priv_lock, flags);

CRA Git | Maintained and supported by SUSTech CRA and CCSE