Commit 264813ac authored Mar 21, 2016 by Liu Bo Committed by David Sterba Apr 04, 2016

Btrfs: fix invalid reference in replace_path



Dan Carpenter's static checker has found this error, it's introduced by
commit 64c043de
("Btrfs: fix up read_tree_block to return proper error")

It's really supposed to 'break' the loop on error like others.

Cc: Dan Carpenter <dan.carpenter@oracle.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 2a162ce9

fs/btrfs/relocation.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -1850,6 +1850,7 @@ again:
	eb = read_tree_block(dest, old_bytenr, old_ptr_gen);		eb = read_tree_block(dest, old_bytenr, old_ptr_gen);
	if (IS_ERR(eb)) {		if (IS_ERR(eb)) {
	ret = PTR_ERR(eb);		ret = PTR_ERR(eb);
			break;
	} else if (!extent_buffer_uptodate(eb)) {		} else if (!extent_buffer_uptodate(eb)) {
	ret = -EIO;		ret = -EIO;
	free_extent_buffer(eb);		free_extent_buffer(eb);

Admin message