Commit 2644a3cc authored Apr 19, 2017 by Bart Van Assche Committed by Jens Axboe Apr 19, 2017

null_blk: Use blk_init_request_from_bio() instead of open-coding it



This patch changes the behavior of the null_blk driver for the
LightNVM mode as follows:
* REQ_FAILFAST_MASK is set for read-ahead requests.
* If no I/O priority has been set in the bio, the I/O priority is
  copied from the I/O context.
* The rq_disk member is initialized if bio->bi_bdev != NULL.
* req->errors is initialized to zero.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Matias Bjørling <m@bjorling.me>
Cc: Adam Manzanares <adam.manzanares@wdc.com>
Signed-off-by: Jens Axboe <axboe@fb.com>

parent da8d7f07

drivers/block/null_blk.c

+1 −8

Original line number	Diff line number	Diff line
		@@ -443,14 +443,7 @@ static int null_lnvm_submit_io(struct nvm_dev dev, struct nvm_rq rqd)
		if (IS_ERR(rq))
		return -ENOMEM;

		rq->__sector = bio->bi_iter.bi_sector;
		rq->ioprio = bio_prio(bio);

		if (bio_has_data(bio))
		rq->nr_phys_segments = bio_phys_segments(q, bio);

		rq->__data_len = bio->bi_iter.bi_size;
		rq->bio = rq->biotail = bio;
		blk_init_request_from_bio(rq, bio);

		rq->end_io_data = rqd;

Admin message