Commit 260c3b34 authored by Yangyang Li's avatar Yangyang Li Committed by Doug Ledford
Browse files

RDMA/hns: Refactor hns_roce_v2_set_hem for hip08 



In order to reduce the complexity of hns_roce_v2_set_hem, extract
the implementation of op as a function.

Signed-off-by: default avatarYangyang Li <liyangyang20@huawei.com>
Link: https://lore.kernel.org/r/1565276034-97329-12-git-send-email-oulijun@huawei.com


Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 4b42d05d

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+42 −33
Original line number Diff line number Diff line
@@ -2903,11 +2903,49 @@ static int hns_roce_v2_poll_cq(struct ib_cq *ibcq, int num_entries, 
	return npolled;

}



static int get_op_for_set_hem(struct hns_roce_dev *hr_dev, u32 type,

			      int step_idx)

{

	int op;



	if (type == HEM_TYPE_SCCC && step_idx)

		return -EINVAL;



	switch (type) {

	case HEM_TYPE_QPC:

		op = HNS_ROCE_CMD_WRITE_QPC_BT0;

		break;

	case HEM_TYPE_MTPT:

		op = HNS_ROCE_CMD_WRITE_MPT_BT0;

		break;

	case HEM_TYPE_CQC:

		op = HNS_ROCE_CMD_WRITE_CQC_BT0;

		break;

	case HEM_TYPE_SRQC:

		op = HNS_ROCE_CMD_WRITE_SRQC_BT0;

		break;

	case HEM_TYPE_SCCC:

		op = HNS_ROCE_CMD_WRITE_SCCC_BT0;

		break;

	case HEM_TYPE_QPC_TIMER:

		op = HNS_ROCE_CMD_WRITE_QPC_TIMER_BT0;

		break;

	case HEM_TYPE_CQC_TIMER:

		op = HNS_ROCE_CMD_WRITE_CQC_TIMER_BT0;

		break;

	default:

		dev_warn(hr_dev->dev,

			 "Table %d not to be written by mailbox!\n", type);

		return -EINVAL;

	}



	return op + step_idx;

}



static int hns_roce_v2_set_hem(struct hns_roce_dev *hr_dev,

			       struct hns_roce_hem_table *table, int obj,

			       int step_idx)

{

	struct device *dev = hr_dev->dev;

	struct hns_roce_cmd_mailbox *mailbox;

	struct hns_roce_hem_iter iter;

	struct hns_roce_hem_mhop mhop;
@@ -2920,7 +2958,7 @@ static int hns_roce_v2_set_hem(struct hns_roce_dev *hr_dev, 
	u64 bt_ba = 0;

	u32 chunk_ba_num;

	u32 hop_num;

	u16 op = 0xff;

	int op;



	if (!hns_roce_check_whether_mhop(hr_dev, table->type))

		return 0;
@@ -2942,39 +2980,10 @@ static int hns_roce_v2_set_hem(struct hns_roce_dev *hr_dev, 
		hem_idx = i;

	}



	switch (table->type) {

	case HEM_TYPE_QPC:

		op = HNS_ROCE_CMD_WRITE_QPC_BT0;

		break;

	case HEM_TYPE_MTPT:

		op = HNS_ROCE_CMD_WRITE_MPT_BT0;

		break;

	case HEM_TYPE_CQC:

		op = HNS_ROCE_CMD_WRITE_CQC_BT0;

		break;

	case HEM_TYPE_SRQC:

		op = HNS_ROCE_CMD_WRITE_SRQC_BT0;

		break;

	case HEM_TYPE_SCCC:

		op = HNS_ROCE_CMD_WRITE_SCCC_BT0;

		break;

	case HEM_TYPE_QPC_TIMER:

		op = HNS_ROCE_CMD_WRITE_QPC_TIMER_BT0;

		break;

	case HEM_TYPE_CQC_TIMER:

		op = HNS_ROCE_CMD_WRITE_CQC_TIMER_BT0;

		break;

	default:

		dev_warn(dev, "Table %d not to be written by mailbox!\n",

			 table->type);

		return 0;

	}



	if (table->type == HEM_TYPE_SCCC && step_idx)

	op = get_op_for_set_hem(hr_dev, table->type, step_idx);

	if (op == -EINVAL)

		return 0;



	op += step_idx;



	mailbox = hns_roce_alloc_cmd_mailbox(hr_dev);

	if (IS_ERR(mailbox))

		return PTR_ERR(mailbox);

CRA Git | Maintained and supported by SUSTech CRA and CCSE