Commit 26073918 authored Dec 20, 2018 by YueHaibing Committed by Bartlomiej Zolnierkiewicz Dec 20, 2018

video: fbdev: pxafb: Fix "WARNING: invalid free of devm_ allocated data"



'info->modes' got allocated with devm_kcalloc in of_get_pxafb_display.

This gives this error message:
  ./drivers/video/fbdev/pxafb.c:2238:2-7: WARNING: invalid free of devm_ allocated data

Fixes: c8f96304 ("video: fbdev: pxafb: switch to devm_* API")
Cc: stable@kernel.org [v4.19+]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Daniel Mack <daniel@zonque.org>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

parent f75df8d4

drivers/video/fbdev/pxafb.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -2234,10 +2234,8 @@ static struct pxafb_mach_info of_pxafb_of_mach_info(struct device dev)
		if (!info)
		return ERR_PTR(-ENOMEM);
		ret = of_get_pxafb_mode_info(dev, info);
		if (ret) {
		kfree(info->modes);
		if (ret)
		return ERR_PTR(ret);
		}

		/*
		* On purpose, neither lccrX registers nor video memory size can be

Admin message