Commit 25cc72a3 authored by Ido Schimmel's avatar Ido Schimmel Committed by David S. Miller
Browse files

mlxsw: spectrum: Forbid linking to devices that have uppers 



The mlxsw driver relies on NETDEV_CHANGEUPPER events to configure the
device in case a port is enslaved to a master netdev such as bridge or
bond.

Since the driver ignores events unrelated to its ports and their
uppers, it's possible to engineer situations in which the device's data
path differs from the kernel's.

One example to such a situation is when a port is enslaved to a bond
that is already enslaved to a bridge. When the bond was enslaved the
driver ignored the event - as the bond wasn't one of its uppers - and
therefore a bridge port instance isn't created in the device.

Until such configurations are supported forbid them by checking that the
upper device doesn't have uppers of its own.

Fixes: 0d65fc13 ("mlxsw: spectrum: Implement LAG port join/leave")
Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
Reported-by: default avatarNogah Frankel <nogahf@mellanox.com>
Tested-by: default avatarNogah Frankel <nogahf@mellanox.com>
Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f581a0dd

drivers/net/ethernet/mellanox/mlxsw/spectrum.c

+6 −0
Original line number Diff line number Diff line
@@ -4139,6 +4139,8 @@ static int mlxsw_sp_netdevice_port_upper_event(struct net_device *lower_dev, 
			return -EINVAL;

		if (!info->linking)

			break;

		if (netdev_has_any_upper_dev(upper_dev))

			return -EINVAL;

		if (netif_is_lag_master(upper_dev) &&

		    !mlxsw_sp_master_lag_check(mlxsw_sp, upper_dev,

					       info->upper_info))
@@ -4258,6 +4260,10 @@ static int mlxsw_sp_netdevice_port_vlan_event(struct net_device *vlan_dev, 
		upper_dev = info->upper_dev;

		if (!netif_is_bridge_master(upper_dev))

			return -EINVAL;

		if (!info->linking)

			break;

		if (netdev_has_any_upper_dev(upper_dev))

			return -EINVAL;

		break;

	case NETDEV_CHANGEUPPER:

		upper_dev = info->upper_dev;

include/linux/netdevice.h

+2 −0
Original line number Diff line number Diff line
@@ -3866,6 +3866,8 @@ int netdev_walk_all_upper_dev_rcu(struct net_device *dev, 
bool netdev_has_upper_dev_all_rcu(struct net_device *dev,

				  struct net_device *upper_dev);



bool netdev_has_any_upper_dev(struct net_device *dev);



void *netdev_lower_get_next_private(struct net_device *dev,

				    struct list_head **iter);

void *netdev_lower_get_next_private_rcu(struct net_device *dev,

net/core/dev.c

+2 −1
Original line number Diff line number Diff line
@@ -5668,12 +5668,13 @@ EXPORT_SYMBOL(netdev_has_upper_dev_all_rcu); 
 * Find out if a device is linked to an upper device and return true in case

 * it is. The caller must hold the RTNL lock.

 */

static bool netdev_has_any_upper_dev(struct net_device *dev)

bool netdev_has_any_upper_dev(struct net_device *dev)

{

	ASSERT_RTNL();



	return !list_empty(&dev->adj_list.upper);

}

EXPORT_SYMBOL(netdev_has_any_upper_dev);



/**

 * netdev_master_upper_dev_get - Get master upper device

CRA Git | Maintained and supported by SUSTech CRA and CCSE