Commit 25c7704d authored by Pravin B Shelar's avatar Pravin B Shelar Committed by David S. Miller
Browse files

ipv4: Fix ip-header identification for gso packets. 



ip-header id needs to be incremented even if IP_DF flag is set.
This behaviour was changed in commit 490ab081
(IP_GRE: Fix IP-Identification).

Following patch fixes it so that identification is always
incremented.

Reported-by: default avatarCong Wang <amwang@redhat.com>
Acked-by: default avatarCong Wang <amwang@redhat.com>
Signed-off-by: default avatarPravin B Shelar <pshelar@nicira.com>
parent 5594c321

include/net/ipip.h

+6 −10
Original line number Diff line number Diff line
@@ -74,9 +74,6 @@ static inline void tunnel_ip_select_ident(struct sk_buff *skb, 
{

	struct iphdr *iph = ip_hdr(skb);



	if (iph->frag_off & htons(IP_DF))

		iph->id	= 0;

	else {

	/* Use inner packet iph-id if possible. */

	if (skb->protocol == htons(ETH_P_IP) && old_iph->id)

		iph->id	= old_iph->id;
@@ -84,5 +81,4 @@ static inline void tunnel_ip_select_ident(struct sk_buff *skb, 
		__ip_select_ident(iph, dst,

				  (skb_shinfo(skb)->gso_segs ?: 1) - 1);

}

}

#endif

net/ipv4/af_inet.c

+1 −2
Original line number Diff line number Diff line
@@ -1334,7 +1334,6 @@ static struct sk_buff *inet_gso_segment(struct sk_buff *skb, 
				iph->frag_off |= htons(IP_MF);

			offset += (skb->len - skb->mac_len - iph->ihl * 4);

		} else  {

			if (!(iph->frag_off & htons(IP_DF)))

			iph->id = htons(id++);

		}

		iph->tot_len = htons(skb->len - skb->mac_len);

CRA Git | Maintained and supported by SUSTech CRA and CCSE