Commit 25bff6d5 authored Jun 25, 2019 by Xin Long Committed by David S. Miller Jun 26, 2019

sctp: change to hold sk after auth shkey is created successfully



Now in sctp_endpoint_init(), it holds the sk then creates auth
shkey. But when the creation fails, it doesn't release the sk,
which causes a sk defcnf leak,

Here to fix it by only holding the sk when auth shkey is created
successfully.

Fixes: a29a5bd4 ("[SCTP]: Implement SCTP-AUTH initializations.")
Reported-by:  <syzbot+afabda3890cc2f765041@syzkaller.appspotmail.com>
Reported-by:  <syzbot+276ca1c77a19977c0130@syzkaller.appspotmail.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Neil Horman <nhorman@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 13696531

net/sctp/endpointola.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -118,10 +118,6 @@ static struct sctp_endpoint sctp_endpoint_init(struct sctp_endpoint ep,
		/* Initialize the bind addr area */
		sctp_bind_addr_init(&ep->base.bind_addr, 0);

		/* Remember who we are attached to. */
		ep->base.sk = sk;
		sock_hold(ep->base.sk);

		/* Create the lists of associations. */
		INIT_LIST_HEAD(&ep->asocs);

		@@ -154,6 +150,10 @@ static struct sctp_endpoint sctp_endpoint_init(struct sctp_endpoint ep,
		ep->prsctp_enable = net->sctp.prsctp_enable;
		ep->reconf_enable = net->sctp.reconf_enable;

		/* Remember who we are attached to. */
		ep->base.sk = sk;
		sock_hold(ep->base.sk);

		return ep;

		nomem_shkey:

Admin message