Commit 25b8ff68 authored by Felipe Balbi's avatar Felipe Balbi
Browse files

usb: dwc3: fix few coding style problems 



There were a few coding style issues with this driver
which are now fixed:

drivers/usb/dwc3/debugfs.c:48: WARNING: Use #include \
	<linux/uaccess.h> instead of <asm/uaccess.h>
drivers/usb/dwc3/debugfs.c:484: ERROR: space required \
	before the open brace '{'
drivers/usb/dwc3/ep0.c:261: WARNING: line over 80 characters
drivers/usb/dwc3/ep0.c:287: WARNING: suspect code indent \
	for conditional statements (16, 23)
drivers/usb/dwc3/gadget.c:749: WARNING: line over 80 characters
drivers/usb/dwc3/gadget.c:1267: WARNING: line over 80 characters
drivers/usb/dwc3/gadget.h:116: WARNING: line over 80 characters
drivers/usb/dwc3/io.h:42: WARNING: Use #include \
	<linux/io.h> instead of <asm/io.h>

Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 4878a028

drivers/usb/dwc3/debugfs.c

+2 −3
Original line number Diff line number Diff line
@@ -44,8 +44,7 @@ 
#include <linux/debugfs.h>

#include <linux/seq_file.h>

#include <linux/delay.h>



#include <asm/uaccess.h>

#include <linux/uaccess.h>



#include "core.h"

#include "gadget.h"

drivers/usb/dwc3/ep0.c

+3 −2
Original line number Diff line number Diff line
@@ -258,7 +258,8 @@ static void dwc3_ep0_status_cmpl(struct usb_ep *ep, struct usb_request *req) 
/*

 * ch 9.4.5

 */

static int dwc3_ep0_handle_status(struct dwc3 *dwc, struct usb_ctrlrequest *ctrl)

static int dwc3_ep0_handle_status(struct dwc3 *dwc,

		struct usb_ctrlrequest *ctrl)

{

	struct dwc3_ep		*dep;

	u32			recip;

drivers/usb/dwc3/gadget.c

+5 −5
Original line number Diff line number Diff line
@@ -745,8 +745,9 @@ static int __dwc3_gadget_kick_transfer(struct dwc3_ep *dep, u16 cmd_param, 
	dep->flags |= DWC3_EP_BUSY;

	dep->res_trans_idx = dwc3_gadget_ep_get_transfer_index(dwc,

			dep->number);

	if (!dep->res_trans_idx)

		printk_once(KERN_ERR "%s() res_trans_idx is invalid\n", __func__);



	WARN_ON_ONCE(!dep->res_trans_idx);



	return 0;

}
@@ -1264,11 +1265,10 @@ static int __devinit dwc3_gadget_init_endpoints(struct dwc3 *dwc) 
					&dwc->gadget.ep_list);



			ret = dwc3_alloc_trb_pool(dep);

			if (ret) {

				dev_err(dwc->dev, "%s: failed to allocate TRB pool\n", dep->name);

			if (ret)

				return ret;

		}

		}



		INIT_LIST_HEAD(&dep->request_list);

		INIT_LIST_HEAD(&dep->req_queued);

	}

drivers/usb/dwc3/gadget.h

+2 −1
Original line number Diff line number Diff line
@@ -113,7 +113,8 @@ static inline void dwc3_gadget_move_request_queued(struct dwc3_request *req) 
void dwc3_gadget_giveback(struct dwc3_ep *dep, struct dwc3_request *req,

		int status);



void dwc3_ep0_interrupt(struct dwc3 *dwc, const struct dwc3_event_depevt *event);

void dwc3_ep0_interrupt(struct dwc3 *dwc,

		const struct dwc3_event_depevt *event);

void dwc3_ep0_out_start(struct dwc3 *dwc);

int dwc3_gadget_ep0_queue(struct usb_ep *ep, struct usb_request *request,

		gfp_t gfp_flags);

drivers/usb/dwc3/io.h

+1 −1
Original line number Diff line number Diff line
@@ -39,7 +39,7 @@ 
#ifndef __DRIVERS_USB_DWC3_IO_H

#define __DRIVERS_USB_DWC3_IO_H



#include <asm/io.h>

#include <linux/io.h>



static inline u32 dwc3_readl(void __iomem *base, u32 offset)

{

CRA Git | Maintained and supported by SUSTech CRA and CCSE