scsi: target: loop, usb, vhost, xen: use target_remove_session (25b88550) · Commits · 戴 / test

This converts drivers that were only calling transport_deregister_session to use target_remove_session. The calling of transport_deregister_session_configfs via target_remove_session for these types of drivers is ok, because they were not exporting info from fields like sess_acl_list, sess->se_tpg and sess->fabric_sess_ptr from configfs accessible functions, so they will see no difference. Signed-off-by:

Mike Christie <mchristi@redhat.com> Reviewed-by:

Bart Van Assche <bart.vanassche@wdc.com> Reviewed-by:

Christoph Hellwig <hch@lst.de> Cc: Felipe Balbi <balbi@kernel.org> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Cc: Andrzej Pietrasiewicz <andrzej.p@samsung.com> Cc: Michael S. Tsirkin <mst@redhat.com> Cc: Juergen Gross <jgross@suse.com> Signed-off-by:

Martin K. Petersen <martin.petersen@oracle.com>

drivers/target/loopback/tcm_loop.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -805,7 +805,7 @@ static int tcm_loop_drop_nexus(
		/*
		* Release the SCSI I_T Nexus to the emulated Target Port
		*/
		transport_deregister_session(tl_nexus->se_sess);
		target_remove_session(se_sess);
		tpg->tl_nexus = NULL;
		kfree(tl_nexus);
		return 0;

drivers/usb/gadget/function/f_tcm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1638,7 +1638,7 @@ static int tcm_usbg_drop_nexus(struct usbg_tpg *tpg)
		/*
		* Release the SCSI I_T Nexus to the emulated vHost Target Port
		*/
		transport_deregister_session(tv_nexus->tvn_se_sess);
		target_remove_session(se_sess);
		tpg->tpg_nexus = NULL;

		kfree(tv_nexus);

drivers/vhost/scsi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1797,7 +1797,7 @@ static int vhost_scsi_drop_nexus(struct vhost_scsi_tpg *tpg)
		/*
		* Release the SCSI I_T Nexus to the emulated vhost Target Port
		*/
		transport_deregister_session(tv_nexus->tvn_se_sess);
		target_remove_session(se_sess);
		tpg->tpg_nexus = NULL;
		mutex_unlock(&tpg->tv_tpg_mutex);

drivers/xen/xen-scsiback.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1576,7 +1576,7 @@ static int scsiback_drop_nexus(struct scsiback_tpg *tpg)
		/*
		* Release the SCSI I_T Nexus to the emulated xen-pvscsi Target Port
		*/
		transport_deregister_session(tv_nexus->tvn_se_sess);
		target_remove_session(se_sess);
		tpg->tpg_nexus = NULL;
		mutex_unlock(&tpg->tv_tpg_mutex);

Admin message