Commit 25a6e6b8 authored Sep 03, 2013 by Thomas Graf Committed by David S. Miller Sep 04, 2013

ipv6: Don't depend on per socket memory for neighbour discovery messages



Allocating skbs when sending out neighbour discovery messages
currently uses sock_alloc_send_skb() based on a per net namespace
socket and thus share a socket wmem buffer space.

If a netdevice is temporarily unable to transmit due to carrier
loss or for other reasons, the queued up ndisc messages will cosnume
all of the wmem space and will thus prevent from any more skbs to
be allocated even for netdevices that are able to transmit packets.

The number of neighbour discovery messages sent is very limited,
use of alloc_skb() bypasses the socket wmem buffer size enforcement
while the manual call to skb_set_owner_w() maintains the socket
reference needed for the IPv6 output path.

This patch has orginally been posted by Eric Dumazet in a modified
form.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Fabio Estevam <festevam@gmail.com>
Tested-by: Fabio Estevam <fabio.estevam@freescale.com>
Tested-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 36e24e2e

net/ipv6/ndisc.c

+8 −6

Original line number	Diff line number	Diff line
		@@ -372,14 +372,11 @@ static struct sk_buff ndisc_alloc_skb(struct net_device dev,
		int tlen = dev->needed_tailroom;
		struct sock *sk = dev_net(dev)->ipv6.ndisc_sk;
		struct sk_buff *skb;
		int err;

		skb = sock_alloc_send_skb(sk,
		hlen + sizeof(struct ipv6hdr) + len + tlen,
		1, &err);
		skb = alloc_skb(hlen + sizeof(struct ipv6hdr) + len + tlen, GFP_ATOMIC);
		if (!skb) {
		ND_PRINTK(0, err, "ndisc: %s failed to allocate an skb, err=%d\n",
		__func__, err);
		ND_PRINTK(0, err, "ndisc: %s failed to allocate an skb\n",
		__func__);
		return NULL;
		}

		@@ -389,6 +386,11 @@ static struct sk_buff ndisc_alloc_skb(struct net_device dev,
		skb_reserve(skb, hlen + sizeof(struct ipv6hdr));
		skb_reset_transport_header(skb);

		/* Manually assign socket ownership as we avoid calling
		* sock_alloc_send_pskb() to bypass wmem buffer limits
		*/
		skb_set_owner_w(skb, sk);

		return skb;
		}

Admin message