Unverified Commit 25972d0c authored Oct 12, 2018 by Phil Elwell Committed by Mark Brown Oct 12, 2018

spi: Make GPIO CSs honour the SPI_NO_CS flag



The SPI configuration state includes an SPI_NO_CS flag that disables
all CS line manipulation, for applications that want to manage their
own chip selects. However, this flag is ignored by the GPIO CS code
in the SPI framework.

Correct this omission with a trivial patch.

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 44221eba

drivers/spi/spi.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -775,6 +775,8 @@ static void spi_set_cs(struct spi_device *spi, bool enable)
		enable = !enable;

		if (gpio_is_valid(spi->cs_gpio)) {
		/* Honour the SPI_NO_CS flag */
		if (!(spi->mode & SPI_NO_CS))
		gpio_set_value(spi->cs_gpio, !enable);
		/* Some SPI masters need both GPIO CS & slave_select */
		if ((spi->controller->flags & SPI_MASTER_GPIO_SS) &&

Admin message