Commit 25915302 authored Jan 06, 2010 by Johan Hovold Committed by Greg Kroah-Hartman Jan 20, 2010

usb: serial: fix memory leak in generic driver



Fix a regression introduced by commit
715b1dc0 ("USB: usb_debug,
usb_generic_serial: implement multi urb write").

URB transfer buffer was never freed when using multi-urb writes. 
Currently the only driver enabling multi-urb writes is usb_debug.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Cc: Greg KH <greg@kroah.com>
Acked-by: Jason Wessel <jason.wessel@windriver.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 25719e6b

drivers/usb/serial/generic.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -489,6 +489,8 @@ void usb_serial_generic_write_bulk_callback(struct urb *urb)
		dbg("%s - port %d", __func__, port->number);

		if (port->serial->type->max_in_flight_urbs) {
		kfree(urb->transfer_buffer);

		spin_lock_irqsave(&port->lock, flags);
		--port->urbs_in_flight;
		port->tx_bytes_flight -= urb->transfer_buffer_length;

Admin message