Commit 2583d706 authored by Benjamin Tissoires's avatar Benjamin Tissoires Committed by Gustavo Padovan
Browse files

Bluetooth: hidp: implement hidinput_input_event callback 



We can re-enable hidinput_input_event to allow the leds of bluetooth
keyboards to be set.
Now the callbacks uses hid core to retrieve the right HID report to
send, so this version is safer.

Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Reviewed-by: default avatarDavid Herrmann <dh.herrmann@gmail.com>
Acked-by: default avatarJiri Kosina <jkosina@suse.cz>
Signed-off-by: default avatarGustavo Padovan <gustavo.padovan@collabora.co.uk>
parent 1c244f79

net/bluetooth/hidp/core.c

+26 −0
Original line number Diff line number Diff line
@@ -238,6 +238,31 @@ static int hidp_send_report(struct hidp_session *session, struct hid_report *rep 
	return hidp_send_intr_message(session, hdr, buf, rsize);

}



static int hidp_hidinput_event(struct input_dev *dev, unsigned int type,

			       unsigned int code, int value)

{

	struct hid_device *hid = input_get_drvdata(dev);

	struct hidp_session *session = hid->driver_data;

	struct hid_field *field;

	int offset;



	BT_DBG("session %p type %d code %d value %d",

	       session, type, code, value);



	if (type != EV_LED)

		return -1;



	offset = hidinput_find_field(hid, type, code, &field);

	if (offset == -1) {

		hid_warn(dev, "event field not found\n");

		return -1;

	}



	hid_set_field(field, offset, value);



	return hidp_send_report(session, field->report);

}



static int hidp_get_raw_report(struct hid_device *hid,

		unsigned char report_number,

		unsigned char *data, size_t count,
@@ -711,6 +736,7 @@ static struct hid_ll_driver hidp_hid_driver = { 
	.stop = hidp_stop,

	.open  = hidp_open,

	.close = hidp_close,

	.hidinput_input_event = hidp_hidinput_event,

};



/* This function sets up the hid device. It does not add it

CRA Git | Maintained and supported by SUSTech CRA and CCSE