Commit 2583d671 authored Nov 17, 2017 by Vlastimil Babka Committed by Linus Torvalds Nov 17, 2017

mm, compaction: split off flag for not updating skip hints

Pageblock skip hints were added as a heuristic for compaction, which
shares core code with CMA.  Since CMA reliability would suffer from the
heuristics, compact_control flag ignore_skip_hint was added for the CMA
use case.  Since 6815bf3f ("mm/compaction: respect ignore_skip_hint
in update_pageblock_skip") the flag also means that CMA won't *update*
the skip hints in addition to ignoring them.

Today, direct compaction can also ignore the skip hints in the last
resort attempt, but there's no reason not to set them when isolation
fails in such case.  Thus, this patch splits off a new no_set_skip_hint
flag to avoid the updating, which only CMA sets.  This should improve
the heuristics a bit, and allow us to simplify the persistent skip bit
handling as the next step.

Link: http://lkml.kernel.org/r/20171102121706.21504-2-vbabka@suse.cz


Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
Acked-by: Mel Gorman <mgorman@techsingularity.net>
Cc: David Rientjes <rientjes@google.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent b527cfe5

mm/compaction.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -295,7 +295,7 @@ static void update_pageblock_skip(struct compact_control *cc,
		struct zone *zone = cc->zone;
		unsigned long pfn;

		if (cc->ignore_skip_hint)
		if (cc->no_set_skip_hint)
		return;

		if (!page)

mm/internal.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -198,6 +198,7 @@ struct compact_control {
		const int classzone_idx; /* zone index of a direct compactor */
		enum migrate_mode mode; /* Async or sync migration mode */
		bool ignore_skip_hint; /* Scan blocks even if marked skip */
		bool no_set_skip_hint; /* Don't mark blocks for skipping */
		bool ignore_block_suitable; /* Scan blocks considered unsuitable */
		bool direct_compaction; /* False from kcompactd or /proc/... */
		bool whole_zone; /* Whole zone should/has been scanned */

mm/page_alloc.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -7619,6 +7619,7 @@ int alloc_contig_range(unsigned long start, unsigned long end,
		.zone = page_zone(pfn_to_page(start)),
		.mode = MIGRATE_SYNC,
		.ignore_skip_hint = true,
		.no_set_skip_hint = true,
		.gfp_mask = current_gfp_context(gfp_mask),
		};
		INIT_LIST_HEAD(&cc.migratepages);

Admin message