Commit 25718736 authored by Andi Kleen's avatar Andi Kleen Committed by Andi Kleen
Browse files

HWPOISON: Define a new error_remove_page address space op for async truncation 



Truncating metadata pages is not safe right now before
we haven't audited all file systems.

To enable truncation only for data address space define
a new address_space callback error_remove_page.

This is used for memory_failure.c memory error handling.

This can be then set to truncate_inode_page()

This patch just defines the new operation and adds documentation.

Callers and users come in followon patches.

Signed-off-by: default avatarAndi Kleen <ak@linux.intel.com>
parent 83f78668

Documentation/filesystems/vfs.txt

+7 −0
Original line number Diff line number Diff line
@@ -536,6 +536,7 @@ struct address_space_operations { 
	/* migrate the contents of a page to the specified target */

	int (*migratepage) (struct page *, struct page *);

	int (*launder_page) (struct page *);

	int (*error_remove_page) (struct mapping *mapping, struct page *page);

};



  writepage: called by the VM to write a dirty page to backing store.
@@ -694,6 +695,12 @@ struct address_space_operations { 
  	prevent redirtying the page, it is kept locked during the whole

	operation.



  error_remove_page: normally set to generic_error_remove_page if truncation

	is ok for this address space. Used for memory failure handling.

	Setting this implies you deal with pages going away under you,

	unless you have them locked or reference counts increased.





The File Object

===============

include/linux/fs.h

+1 −0
Original line number Diff line number Diff line
@@ -595,6 +595,7 @@ struct address_space_operations { 
	int (*launder_page) (struct page *);

	int (*is_partially_uptodate) (struct page *, read_descriptor_t *,

					unsigned long);

	int (*error_remove_page)(struct address_space *, struct page *);

};



/*

include/linux/mm.h

+1 −0
Original line number Diff line number Diff line
@@ -795,6 +795,7 @@ extern int vmtruncate(struct inode * inode, loff_t offset); 
extern int vmtruncate_range(struct inode * inode, loff_t offset, loff_t end);



int truncate_inode_page(struct address_space *mapping, struct page *page);

int generic_error_remove_page(struct address_space *mapping, struct page *page);



int invalidate_inode_page(struct page *page);

mm/truncate.c

+17 −0
Original line number Diff line number Diff line
@@ -146,6 +146,23 @@ int truncate_inode_page(struct address_space *mapping, struct page *page) 
	return truncate_complete_page(mapping, page);

}



/*

 * Used to get rid of pages on hardware memory corruption.

 */

int generic_error_remove_page(struct address_space *mapping, struct page *page)

{

	if (!mapping)

		return -EINVAL;

	/*

	 * Only punch for normal data pages for now.

	 * Handling other types like directories would need more auditing.

	 */

	if (!S_ISREG(mapping->host->i_mode))

		return -EIO;

	return truncate_inode_page(mapping, page);

}

EXPORT_SYMBOL(generic_error_remove_page);



/*

 * Safely invalidate one page from its pagecache mapping.

 * It only drops clean, unused pages. The page must be locked.

CRA Git | Maintained and supported by SUSTech CRA and CCSE