Commit 256d92bc authored by Adrian Hunter's avatar Adrian Hunter Committed by Arnaldo Carvalho de Melo
Browse files

perf thread-stack: Fix thread stack processing for the idle task 



perf creates a single 'struct thread' to represent the idle task. That
is because threads are identified by PID and TID, and the idle task
always has PID == TID == 0.

However, there are actually separate idle tasks for each CPU. That
creates a problem for thread stack processing which assumes that each
thread has a single stack, not one stack per CPU.

Fix that by passing through the CPU number, and in the case of the idle
"thread", pick the thread stack from an array based on the CPU number.

Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Acked-by: default avatarJiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/20181221120620.9659-8-adrian.hunter@intel.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 139f42f3

tools/perf/builtin-script.c

+2 −2
Original line number Diff line number Diff line
@@ -1182,7 +1182,7 @@ static int perf_sample__fprintf_callindent(struct perf_sample *sample, 
					   struct addr_location *al, FILE *fp)

{

	struct perf_event_attr *attr = &evsel->attr;

	size_t depth = thread_stack__depth(thread);

	size_t depth = thread_stack__depth(thread, sample->cpu);

	const char *name = NULL;

	static int spacing;

	int len = 0;
@@ -1716,7 +1716,7 @@ static bool show_event(struct perf_sample *sample, 
		       struct thread *thread,

		       struct addr_location *al)

{

	int depth = thread_stack__depth(thread);

	int depth = thread_stack__depth(thread, sample->cpu);



	if (!symbol_conf.graph_function)

		return true;

tools/perf/util/intel-bts.c

+2 −2
Original line number Diff line number Diff line
@@ -451,7 +451,7 @@ static int intel_bts_process_buffer(struct intel_bts_queue *btsq, 
			continue;

		intel_bts_get_branch_type(btsq, branch);

		if (btsq->bts->synth_opts.thread_stack)

			thread_stack__event(thread, btsq->sample_flags,

			thread_stack__event(thread, btsq->cpu, btsq->sample_flags,

					    le64_to_cpu(branch->from),

					    le64_to_cpu(branch->to),

					    btsq->intel_pt_insn.length,
@@ -523,7 +523,7 @@ static int intel_bts_process_queue(struct intel_bts_queue *btsq, u64 *timestamp) 
	    !btsq->bts->synth_opts.thread_stack && thread &&

	    (!old_buffer || btsq->bts->sampling_mode ||

	     (btsq->bts->snapshot_mode && !buffer->consecutive)))

		thread_stack__set_trace_nr(thread, buffer->buffer_nr + 1);

		thread_stack__set_trace_nr(thread, btsq->cpu, buffer->buffer_nr + 1);



	err = intel_bts_process_buffer(btsq, buffer, thread);

tools/perf/util/intel-pt.c

+3 −3
Original line number Diff line number Diff line
@@ -1174,7 +1174,7 @@ static void intel_pt_prep_sample(struct intel_pt *pt, 
	intel_pt_prep_b_sample(pt, ptq, event, sample);



	if (pt->synth_opts.callchain) {

		thread_stack__sample(ptq->thread, ptq->chain,

		thread_stack__sample(ptq->thread, ptq->cpu, ptq->chain,

				     pt->synth_opts.callchain_sz + 1,

				     sample->ip, pt->kernel_start);

		sample->callchain = ptq->chain;
@@ -1526,11 +1526,11 @@ static int intel_pt_sample(struct intel_pt_queue *ptq) 
		return 0;



	if (pt->synth_opts.callchain || pt->synth_opts.thread_stack)

		thread_stack__event(ptq->thread, ptq->flags, state->from_ip,

		thread_stack__event(ptq->thread, ptq->cpu, ptq->flags, state->from_ip,

				    state->to_ip, ptq->insn_len,

				    state->trace_nr);

	else

		thread_stack__set_trace_nr(ptq->thread, state->trace_nr);

		thread_stack__set_trace_nr(ptq->thread, ptq->cpu, state->trace_nr);



	if (pt->sample_branches) {

		err = intel_pt_synth_branch_sample(ptq);

tools/perf/util/thread-stack.c

+58 −14
Original line number Diff line number Diff line
@@ -15,6 +15,7 @@ 


#include <linux/rbtree.h>

#include <linux/list.h>

#include <linux/log2.h>

#include <errno.h>

#include "thread.h"

#include "event.h"
@@ -75,6 +76,16 @@ struct thread_stack { 
	unsigned int arr_sz;

};



/*

 * Assume pid == tid == 0 identifies the idle task as defined by

 * perf_session__register_idle_thread(). The idle task is really 1 task per cpu,

 * and therefore requires a stack for each cpu.

 */

static inline bool thread_stack__per_cpu(struct thread *thread)

{

	return !(thread->tid || thread->pid_);

}



static int thread_stack__grow(struct thread_stack *ts)

{

	struct thread_stack_entry *new_stack;
@@ -111,13 +122,16 @@ static int thread_stack__init(struct thread_stack *ts, struct thread *thread, 
	return 0;

}



static struct thread_stack *thread_stack__new(struct thread *thread,

static struct thread_stack *thread_stack__new(struct thread *thread, int cpu,

					      struct call_return_processor *crp)

{

	struct thread_stack *ts = thread->ts, *new_ts;

	unsigned int old_sz = ts ? ts->arr_sz : 0;

	unsigned int new_sz = 1;



	if (thread_stack__per_cpu(thread) && cpu > 0)

		new_sz = roundup_pow_of_two(cpu + 1);



	if (!ts || new_sz > old_sz) {

		new_ts = calloc(new_sz, sizeof(*ts));

		if (!new_ts)
@@ -130,6 +144,10 @@ static struct thread_stack *thread_stack__new(struct thread *thread, 
		ts = new_ts;

	}



	if (thread_stack__per_cpu(thread) && cpu > 0 &&

	    (unsigned int)cpu < ts->arr_sz)

		ts += cpu;



	if (!ts->stack &&

	    thread_stack__init(ts, thread, crp))

		return NULL;
@@ -137,9 +155,34 @@ static struct thread_stack *thread_stack__new(struct thread *thread, 
	return ts;

}



static inline struct thread_stack *thread__stack(struct thread *thread)

static struct thread_stack *thread__cpu_stack(struct thread *thread, int cpu)

{

	return thread ? thread->ts : NULL;

	struct thread_stack *ts = thread->ts;



	if (cpu < 0)

		cpu = 0;



	if (!ts || (unsigned int)cpu >= ts->arr_sz)

		return NULL;



	ts += cpu;



	if (!ts->stack)

		return NULL;



	return ts;

}



static inline struct thread_stack *thread__stack(struct thread *thread,

						    int cpu)

{

	if (!thread)

		return NULL;



	if (thread_stack__per_cpu(thread))

		return thread__cpu_stack(thread, cpu);



	return thread->ts;

}



static int thread_stack__push(struct thread_stack *ts, u64 ret_addr,
@@ -270,16 +313,16 @@ int thread_stack__flush(struct thread *thread) 
	return err;

}



int thread_stack__event(struct thread *thread, u32 flags, u64 from_ip,

int thread_stack__event(struct thread *thread, int cpu, u32 flags, u64 from_ip,

			u64 to_ip, u16 insn_len, u64 trace_nr)

{

	struct thread_stack *ts = thread__stack(thread);

	struct thread_stack *ts = thread__stack(thread, cpu);



	if (!thread)

		return -EINVAL;



	if (!ts) {

		ts = thread_stack__new(thread, NULL);

		ts = thread_stack__new(thread, cpu, NULL);

		if (!ts) {

			pr_warning("Out of memory: no thread stack\n");

			return -ENOMEM;
@@ -329,9 +372,9 @@ int thread_stack__event(struct thread *thread, u32 flags, u64 from_ip, 
	return 0;

}



void thread_stack__set_trace_nr(struct thread *thread, u64 trace_nr)

void thread_stack__set_trace_nr(struct thread *thread, int cpu, u64 trace_nr)

{

	struct thread_stack *ts = thread__stack(thread);

	struct thread_stack *ts = thread__stack(thread, cpu);



	if (!ts)

		return;
@@ -375,10 +418,11 @@ static inline u64 callchain_context(u64 ip, u64 kernel_start) 
	return ip < kernel_start ? PERF_CONTEXT_USER : PERF_CONTEXT_KERNEL;

}



void thread_stack__sample(struct thread *thread, struct ip_callchain *chain,

void thread_stack__sample(struct thread *thread, int cpu,

			  struct ip_callchain *chain,

			  size_t sz, u64 ip, u64 kernel_start)

{

	struct thread_stack *ts = thread__stack(thread);

	struct thread_stack *ts = thread__stack(thread, cpu);

	u64 context = callchain_context(ip, kernel_start);

	u64 last_context;

	size_t i, j;
@@ -651,7 +695,7 @@ int thread_stack__process(struct thread *thread, struct comm *comm, 
			  struct addr_location *to_al, u64 ref,

			  struct call_return_processor *crp)

{

	struct thread_stack *ts = thread__stack(thread);

	struct thread_stack *ts = thread__stack(thread, sample->cpu);

	int err = 0;



	if (ts && !ts->crp) {
@@ -661,7 +705,7 @@ int thread_stack__process(struct thread *thread, struct comm *comm, 
	}



	if (!ts) {

		ts = thread_stack__new(thread, crp);

		ts = thread_stack__new(thread, sample->cpu, crp);

		if (!ts)

			return -ENOMEM;

		ts->comm = comm;
@@ -726,9 +770,9 @@ int thread_stack__process(struct thread *thread, struct comm *comm, 
	return err;

}



size_t thread_stack__depth(struct thread *thread)

size_t thread_stack__depth(struct thread *thread, int cpu)

{

	struct thread_stack *ts = thread__stack(thread);

	struct thread_stack *ts = thread__stack(thread, cpu);



	if (!ts)

		return 0;

tools/perf/util/thread-stack.h

+4 −4
Original line number Diff line number Diff line
@@ -80,14 +80,14 @@ struct call_return_processor { 
	void *data;

};



int thread_stack__event(struct thread *thread, u32 flags, u64 from_ip,

int thread_stack__event(struct thread *thread, int cpu, u32 flags, u64 from_ip,

			u64 to_ip, u16 insn_len, u64 trace_nr);

void thread_stack__set_trace_nr(struct thread *thread, u64 trace_nr);

void thread_stack__sample(struct thread *thread, struct ip_callchain *chain,

void thread_stack__set_trace_nr(struct thread *thread, int cpu, u64 trace_nr);

void thread_stack__sample(struct thread *thread, int cpu, struct ip_callchain *chain,

			  size_t sz, u64 ip, u64 kernel_start);

int thread_stack__flush(struct thread *thread);

void thread_stack__free(struct thread *thread);

size_t thread_stack__depth(struct thread *thread);

size_t thread_stack__depth(struct thread *thread, int cpu);



struct call_return_processor *

call_return_processor__new(int (*process)(struct call_return *cr, void *data),

CRA Git | Maintained and supported by SUSTech CRA and CCSE