Commit 254e4200 authored Dec 06, 2010 by Suresh Siddha Committed by H. Peter Anvin Dec 13, 2010

x86, vt-d: Quirk for masking vtd spec errors to platform error handling logic

On platforms with Intel 7500 chipset, there were some reports of system
hang/NMI's during kexec/kdump in the presence of interrupt-remapping enabled.

During kdump, there is a window where the devices might be still using old
kernel's interrupt information, while the kdump kernel is coming up. This can
cause vt-d faults as the interrupt configuration from the old kernel map to
null IRTE entries in the new kernel etc. (with out interrupt-remapping enabled,
we still have the same issue but in this case we will see benign spurious
interrupt hit the new kernel).

Based on platform config settings, these platforms seem to generate NMI/SMI
when a vt-d fault happens and there were reports that the resulting SMI causes
the system to hang.

Fix it by masking vt-d spec defined errors to platform error reporting logic.
VT-d spec related errors are already handled by the VT-d OS code, so need to
report the same error through other channels.

Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
LKML-Reference: <1291667190.2675.8.camel@sbsiddha-MOBL3.sc.intel.com>
Cc: stable@kernel.org [v2.6.32+]
Reported-by: Max Asbock <masbock@linux.vnet.ibm.com>
Reported-and-tested-by: Takao Indoh <indou.takao@jp.fujitsu.com>
Acked-by: Chris Wright <chrisw@sous-sol.org>
Acked-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>

parent 10340ae1

drivers/pci/quirks.c

+23 −0

Original line number	Diff line number	Diff line
		@@ -2764,6 +2764,29 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_RICOH, PCI_DEVICE_ID_RICOH_R5C832, ricoh_m
		DECLARE_PCI_FIXUP_RESUME_EARLY(PCI_VENDOR_ID_RICOH, PCI_DEVICE_ID_RICOH_R5C832, ricoh_mmc_fixup_r5c832);
		#endif /CONFIG_MMC_RICOH_MMC/

		#if defined(CONFIG_DMAR) \|\| defined(CONFIG_INTR_REMAP)
		#define VTUNCERRMSK_REG 0x1ac
		#define VTD_MSK_SPEC_ERRORS (1 << 31)
		/*
		* This is a quirk for masking vt-d spec defined errors to platform error
		* handling logic. With out this, platforms using Intel 7500, 5500 chipsets
		* (and the derivative chipsets like X58 etc) seem to generate NMI/SMI (based
		* on the RAS config settings of the platform) when a vt-d fault happens.
		* The resulting SMI caused the system to hang.
		*
		* VT-d spec related errors are already handled by the VT-d OS code, so no
		* need to report the same error through other channels.
		*/
		static void vtd_mask_spec_errors(struct pci_dev *dev)
		{
		u32 word;

		pci_read_config_dword(dev, VTUNCERRMSK_REG, &word);
		pci_write_config_dword(dev, VTUNCERRMSK_REG, word \| VTD_MSK_SPEC_ERRORS);
		}
		DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x342e, vtd_mask_spec_errors);
		DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x3c28, vtd_mask_spec_errors);
		#endif

		static void pci_do_fixups(struct pci_dev dev, struct pci_fixup f,
		struct pci_fixup *end)

Admin message