Commit 253fd4ac authored by Israel Rukshin's avatar Israel Rukshin Committed by Keith Busch
Browse files

nvme-pci: Re-order nvme_pci_free_ctrl 



Destroy the resources in the same order like in nvme_probe error flow to
improve code readability.

Signed-off-by: default avatarIsrael Rukshin <israelr@mellanox.com>
Reviewed-by: default avatarMax Gurtovoy <maxg@mellanox.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent 6721c18a

drivers/nvme/host/pci.c

+2 −2
Original line number Diff line number Diff line
@@ -2470,13 +2470,13 @@ static void nvme_pci_free_ctrl(struct nvme_ctrl *ctrl) 
	struct nvme_dev *dev = to_nvme_dev(ctrl);



	nvme_dbbuf_dma_free(dev);

	put_device(dev->dev);

	nvme_free_tagset(dev);

	if (dev->ctrl.admin_q)

		blk_put_queue(dev->ctrl.admin_q);

	kfree(dev->queues);

	free_opal_dev(dev->ctrl.opal_dev);

	mempool_destroy(dev->iod_mempool);

	put_device(dev->dev);

	kfree(dev->queues);

	kfree(dev);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE