Commit 253d9237 authored Feb 16, 2012 by Chris Boot Committed by Nicholas Bellinger May 09, 2012

firewire: Add function to get speed from opaque struct fw_request



Sometimes it's useful to know the FireWire speed of the request that has
just come in to a fw_address_handler callback. As struct fw_request is
opaque we can't peek inside to get the speed out of the struct fw_packet
that's just inside. For example, the SBP-2 spec says:

"The speed at which the block write request to the MANAGEMENT_AGENT
register is received shall determine the speed used by the target for
all subsequent requests to read the initiator’s configuration ROM, fetch
ORB’s from initiator memory or store status at the initiator’s
status_FIFO. Command block ORB’s separately specify the speed for
requests addressed to the data buffer or page table."

[ ANSI T10/1155D Revision 4 page 53/54 ]

Signed-off-by: Chris Boot <bootc@bootc.net>
Acked-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent d5dc28eb

drivers/firewire/core-transaction.c

+9 −0

Original line number	Diff line number	Diff line
		@@ -820,6 +820,15 @@ void fw_send_response(struct fw_card *card,
		}
		EXPORT_SYMBOL(fw_send_response);

		/**
		* fw_get_request_speed() - returns speed at which the @request was received
		*/
		int fw_get_request_speed(struct fw_request *request)
		{
		return request->response.speed;
		}
		EXPORT_SYMBOL(fw_get_request_speed);

		static void handle_exclusive_region_request(struct fw_card *card,
		struct fw_packet *p,
		struct fw_request *request,

include/linux/firewire.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -325,6 +325,7 @@ int fw_core_add_address_handler(struct fw_address_handler *handler,
		void fw_core_remove_address_handler(struct fw_address_handler *handler);
		void fw_send_response(struct fw_card *card,
		struct fw_request *request, int rcode);
		int fw_get_request_speed(struct fw_request *request);
		void fw_send_request(struct fw_card card, struct fw_transaction t,
		int tcode, int destination_id, int generation, int speed,
		unsigned long long offset, void *payload, size_t length,

Admin message