Commit 253babc3 authored by Javier González's avatar Javier González Committed by Jens Axboe
Browse files

lightnvm: pblk: take write semaphore on metadata 



pblk guarantees write ordering at a chunk level through a per open chunk
semaphore. At this point, since we only have an open I/O stream for both
user and GC data, the semaphore is per parallel unit.

For the metadata I/O that is synchronous, the semaphore is not needed as
ordering is guaranteed. However, if the metadata scheme changes or
multiple streams are open, this guarantee might not be preserved.

This patch makes sure that all writes go through the semaphore, even for
synchronous I/O. This is consistent with pblk's write I/O model. It also
simplifies maintenance since changes in the metadata scheme could cause
ordering issues.

Signed-off-by: default avatarJavier González <javier@cnexlabs.com>
Signed-off-by: default avatarMatias Bjørling <mb@lightnvm.io>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent af3fac16

drivers/lightnvm/pblk-core.c

+15 −1
Original line number Diff line number Diff line
@@ -557,6 +557,20 @@ int pblk_submit_io_sync(struct pblk *pblk, struct nvm_rq *rqd) 
	return ret;

}



int pblk_submit_io_sync_sem(struct pblk *pblk, struct nvm_rq *rqd)

{

	struct ppa_addr *ppa_list;

	int ret;



	ppa_list = (rqd->nr_ppas > 1) ? rqd->ppa_list : &rqd->ppa_addr;



	pblk_down_chunk(pblk, ppa_list[0]);

	ret = pblk_submit_io_sync(pblk, rqd);

	pblk_up_chunk(pblk, ppa_list[0]);



	return ret;

}



static void pblk_bio_map_addr_endio(struct bio *bio)

{

	bio_put(bio);
@@ -787,7 +801,7 @@ static int pblk_line_smeta_write(struct pblk *pblk, struct pblk_line *line, 
		meta_list[i].lba = lba_list[paddr] = addr_empty;

	}



	ret = pblk_submit_io_sync(pblk, &rqd);

	ret = pblk_submit_io_sync_sem(pblk, &rqd);

	if (ret) {

		pblk_err(pblk, "smeta I/O submission failed: %d\n", ret);

		bio_put(bio);

drivers/lightnvm/pblk.h

+1 −0
Original line number Diff line number Diff line
@@ -792,6 +792,7 @@ void pblk_log_write_err(struct pblk *pblk, struct nvm_rq *rqd); 
void pblk_log_read_err(struct pblk *pblk, struct nvm_rq *rqd);

int pblk_submit_io(struct pblk *pblk, struct nvm_rq *rqd);

int pblk_submit_io_sync(struct pblk *pblk, struct nvm_rq *rqd);

int pblk_submit_io_sync_sem(struct pblk *pblk, struct nvm_rq *rqd);

int pblk_submit_meta_io(struct pblk *pblk, struct pblk_line *meta_line);

void pblk_check_chunk_state_update(struct pblk *pblk, struct nvm_rq *rqd);

struct bio *pblk_bio_map_addr(struct pblk *pblk, void *data,

CRA Git | Maintained and supported by SUSTech CRA and CCSE