Commit 253216ff authored Feb 23, 2020 by Madhuparna Bhowmik Committed by Johannes Berg Feb 24, 2020

mac80211: rx: avoid RCU list traversal under mutex



local->sta_mtx is held in __ieee80211_check_fast_rx_iface().
No need to use list_for_each_entry_rcu() as it also requires
a cond argument to avoid false lockdep warnings when not used in
RCU read-side section (with CONFIG_PROVE_RCU_LIST).
Therefore use list_for_each_entry();

Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Link: https://lore.kernel.org/r/20200223143302.15390-1-madhuparnabhowmik10@gmail.com


Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent e3ae39ed

net/mac80211/rx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4114,7 +4114,7 @@ void __ieee80211_check_fast_rx_iface(struct ieee80211_sub_if_data *sdata)

		lockdep_assert_held(&local->sta_mtx);

		list_for_each_entry_rcu(sta, &local->sta_list, list) {
		list_for_each_entry(sta, &local->sta_list, list) {
		if (sdata != sta->sdata &&
		(!sta->sdata->bss \|\| sta->sdata->bss != sdata->bss))
		continue;

Admin message