Commit 2530ba5a authored Mar 19, 2020 by Shannon Nelson Committed by David S. Miller Mar 21, 2020

ionic: leave dev cmd request contents alone on FW timeout

It is possible (but unlikely) that FW was busy and missed a heartbeat
check but is still alive and will process the pending request, so don't
clean the dev_cmd in this case. This occasionally occurs when working
with a card that is supporting many devices and is trying to shut them
all down at once, but still wants to see that last LIF disable request.

Fixes: 97ca4865 ("ionic: add heartbeat check")
Signed-off-by: Shannon Nelson <snelson@pensando.io>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4ee7bda4

drivers/net/ethernet/pensando/ionic/ionic_main.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -360,7 +360,10 @@ try_again:
		done, duration / HZ, duration);

		if (!done && hb) {
		ionic_dev_cmd_clean(ionic);
		/* It is possible (but unlikely) that FW was busy and missed a
		* heartbeat check but is still alive and will process this
		* request, so don't clean the dev_cmd in this case.
		*/
		dev_warn(ionic->dev, "DEVCMD %s (%d) failed - FW halted\n",
		ionic_opcode_to_str(opcode), opcode);
		return -ENXIO;

Admin message