Commit 252067e9 authored May 08, 2020 by Weihang Li Committed by Jason Gunthorpe May 19, 2020

RDMA/hns: Remove redundant memcpy()

srq_context is a local variables and is only used to get some fields from
buffer of mailbox. It's meaningless to copy mailbox's buffer's contents
back to it.

Link: https://lore.kernel.org/r/1588931159-56875-8-git-send-email-liweihang@huawei.com


Signed-off-by: Weihang Li <liweihang@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent 7b611d2f

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -5047,8 +5047,6 @@ static int hns_roce_v2_query_srq(struct ib_srq ibsrq, struct ib_srq_attr attr)
		attr->max_wr = srq->wqe_cnt - 1;
		attr->max_sge = srq->max_gs;

		memcpy(srq_context, mailbox->buf, sizeof(*srq_context));

		out:
		hns_roce_free_cmd_mailbox(hr_dev, mailbox);
		return ret;

Admin message