Commit 24db0d75 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jonathan Cameron
Browse files

HID: sensors: remove some unneeded checks 



"report_id" is unsigned so it's never less than zero.  These checks can
be removed without any problem.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent 2b7c4b8e

drivers/hid/hid-sensor-hub.c

+0 −9
Original line number Diff line number Diff line
@@ -214,9 +214,6 @@ int sensor_hub_set_feature(struct hid_sensor_hub_device *hsdev, u32 report_id, 
	struct sensor_hub_data *data =  hid_get_drvdata(hsdev->hdev);

	int ret = 0;



	if (report_id < 0)

		return -EINVAL;



	mutex_lock(&data->mutex);

	report = sensor_hub_report(report_id, hsdev->hdev, HID_FEATURE_REPORT);

	if (!report || (field_index >=  report->maxfield)) {
@@ -241,9 +238,6 @@ int sensor_hub_get_feature(struct hid_sensor_hub_device *hsdev, u32 report_id, 
	struct sensor_hub_data *data =  hid_get_drvdata(hsdev->hdev);

	int ret = 0;



	if (report_id < 0)

		return -EINVAL;



	mutex_lock(&data->mutex);

	report = sensor_hub_report(report_id, hsdev->hdev, HID_FEATURE_REPORT);

	if (!report || (field_index >=  report->maxfield)) {
@@ -271,9 +265,6 @@ int sensor_hub_input_attr_get_raw_value(struct hid_sensor_hub_device *hsdev, 
	struct hid_report *report;

	int ret_val = 0;



	if (report_id < 0)

		return -EINVAL;



	mutex_lock(&data->mutex);

	memset(&data->pending, 0, sizeof(data->pending));

	init_completion(&data->pending.ready);

CRA Git | Maintained and supported by SUSTech CRA and CCSE