Commit 24d481ec authored Sep 19, 2009 by Anton Vorontsov Committed by Live-CD User Sep 19, 2009

8250: Now honours baud rate lower bounds



A platform clock drives 8250 ports in most SOC systems, the clock
might run at high frequencies, and so it's not always possible to
downscale uart clock to a desired value.

Currently the 8250 uart driver accepts not supported baud rates, and
what is worse, it is doing this silently, and then passes not accepted
values to a new termios, so userspace has no chance to catch this kind
of errors (userspace verifies that settings were accepted by reading
back and comparing the settings).

This patch fixes the issue by passing minimum baud rate to the
uart_get_baud_rate() call, the call should take care of all bounds,
so userspace should now report:

  # stty -F /dev/ttyS0 speed 300
  115200
  stty: /dev/ttyS0: unable to perform all requested operations

p.s. uart_get_baud_rate() falls back to 9600, which still might be too
     low for some 10 GHz platforms, but that's a separate issue, and
     we can wait with fixing this till we find such a platform.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 1c2f0493

drivers/serial/8250.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -2272,7 +2272,9 @@ serial8250_set_termios(struct uart_port port, struct ktermios termios,
		/*
		* Ask the core to calculate the divisor for us.
		*/
		baud = uart_get_baud_rate(port, termios, old, 0, port->uartclk/16);
		baud = uart_get_baud_rate(port, termios, old,
		port->uartclk / 16 / 0xffff,
		port->uartclk / 16);
		quot = serial8250_get_divisor(port, baud);

		/*

Admin message