Commit 24c73873 authored Jul 12, 2007 by Bob Peterson Committed by Steven Whitehouse Aug 14, 2007

[GFS2] soft lockup in rgblk_search

This patch seems to fix the problem described in bugzilla bug 246114.
It was written by Steve Whitehouse with some tweaking by me.

The code was looping in the relatively new section of code designed to
search for and reuse unlinked inodes. In cases where it was finding an
appropriate inode to reuse, it was looping around and finding the same
block over and over because a "<=" check should have been a "<" when
comparing the goal block to the last unlinked block found.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

parent bdcb8856

fs/gfs2/rgrp.c

+6 −3

Original line number	Diff line number	Diff line
		@@ -863,12 +863,15 @@ static struct inode try_rgrp_unlink(struct gfs2_rgrpd rgd, u64 *last_unlinked)
		u64 no_addr;

		for(;;) {
		if (goal >= rgd->rd_data)
		break;
		goal = rgblk_search(rgd, goal, GFS2_BLKST_UNLINKED,
		GFS2_BLKST_UNLINKED);
		if (goal == 0)
		return 0;
		break;
		no_addr = goal + rgd->rd_data0;
		if (no_addr <= *last_unlinked)
		goal++;
		if (no_addr < *last_unlinked)
		continue;
		*last_unlinked = no_addr;
		inode = gfs2_inode_lookup(rgd->rd_sbd->sd_vfs, DT_UNKNOWN,

Admin message