Unverified Commit 24c36362 authored Mar 27, 2019 by Rasmus Villemoes Committed by Mark Brown Apr 01, 2019

spi: spi-fsl-spi: remove always-true conditional in fsl_spi_do_one_msg



__spi_validate() in the generic SPI code sets ->speed_hz and
->bits_per_word to non-zero values, so this condition is always true.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 245308c6

drivers/spi/spi-fsl-spi.c

+4 −6

Original line number	Diff line number	Diff line
		@@ -384,12 +384,10 @@ static int fsl_spi_do_one_msg(struct spi_master *master,
		cs_change = 1;
		status = -EINVAL;
		list_for_each_entry(t, &m->transfers, transfer_list) {
		if (t->bits_per_word \|\| t->speed_hz) {
		if (cs_change)
		status = fsl_spi_setup_transfer(spi, t);
		if (status < 0)
		break;
		}

		if (cs_change) {
		fsl_spi_chipselect(spi, BITBANG_CS_ACTIVE);

Admin message