isdn/gigaset: drop debug check on isochronous write (24c17625) · Commits · 戴 / test

With CONFIG_GIGASET_DEBUG set, every isochronous USB frame after an erroneous one was checked for more errors. This produced only noise messages in practice, so drop it. Impact: cleanup Signed-off-by:

Tilman Schmidt <tilman@imap.cc> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/isdn/gigaset/bas-gigaset.c

+0 −18

Original line number	Diff line number	Diff line
		@@ -1188,24 +1188,6 @@ static void write_iso_tasklet(unsigned long data)
		break;
		}
		}
		#ifdef CONFIG_GIGASET_DEBUG
		/* check assumption on remaining frames */
		for (; i < BAS_NUMFRAMES; i++) {
		ifd = &urb->iso_frame_desc[i];
		if (ifd->status != -EINPROGRESS
		\|\| ifd->actual_length != 0) {
		dev_warn(cs->dev,
		"isochronous write: frame %d: %s, "
		"%d of %d bytes sent\n",
		i, get_usb_statmsg(ifd->status),
		ifd->actual_length, ifd->length);
		offset = (ifd->offset +
		ifd->actual_length)
		% BAS_OUTBUFSIZE;
		break;
		}
		}
		#endif
		break;
		case -EPIPE: /* stall - probably underrun */
		dev_err(cs->dev, "isochronous write stalled\n");

Admin message