Btrfs: fix a dio write regression (24c03fa5) · Commits · 戴 / test

This bug is introduced by commit 3b8bde746f6f9bd36a9f05f5f3b6e334318176a9 (Btrfs: lock extents as we map them in DIO). In dio write, we should unlock the section which we didn't do IO on in case that we fall back to buffered write. But we need to not only unlock the section but also cleanup reserved space for the section. This bug was found while running xfstests 133, with this 133 no longer complains. Signed-off-by:

Liu Bo <bo.li.liu@oracle.com> Signed-off-by:

Chris Mason <chris.mason@oracle.com>

fs/btrfs/inode.c

+20 −4

Original line number	Diff line number	Diff line
		@@ -5992,11 +5992,27 @@ unlock:
		* in the case of read we need to unlock only the end area that we
		* aren't using if there is any left over space.
		*/
		if (lockstart < lockend)
		clear_extent_bit(&BTRFS_I(inode)->io_tree, lockstart, lockend,
		unlock_bits, 1, 0, &cached_state, GFP_NOFS);
		else
		if (lockstart < lockend) {
		if (create && len < lockend - lockstart) {
		clear_extent_bit(&BTRFS_I(inode)->io_tree, lockstart,
		lockstart + len - 1, unlock_bits, 1, 0,
		&cached_state, GFP_NOFS);
		/*
		* Beside unlock, we also need to cleanup reserved space
		* for the left range by attaching EXTENT_DO_ACCOUNTING.
		*/
		clear_extent_bit(&BTRFS_I(inode)->io_tree,
		lockstart + len, lockend,
		unlock_bits \| EXTENT_DO_ACCOUNTING,
		1, 0, NULL, GFP_NOFS);
		} else {
		clear_extent_bit(&BTRFS_I(inode)->io_tree, lockstart,
		lockend, unlock_bits, 1, 0,
		&cached_state, GFP_NOFS);
		}
		} else {
		free_extent_state(cached_state);
		}

		free_extent_map(em);

Admin message