drm/fsl-dcu: fix opencoded use of drm_panel_* (24bc3e9c) · Commits · 戴 / test

Use drm_panel_get_modes() to access modes. This has a nice side effect to simplify the code. drm_panel_get_modes() may return a negative value if for example panel is NULL. This is a small change compared to before, but really what we want. v2: - Add more info to changelog (Stefan) Signed-off-by:

Sam Ravnborg <sam@ravnborg.org> Acked-by:

Stefan Agner <stefan@agner.ch> Reviewed-by:

Emil Velikov <emil.velikov@collabora.com> Cc: Alison Wang <alison.wang@nxp.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190804201637.1240-6-sam@ravnborg.org

drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c

+1 −9

Original line number	Diff line number	Diff line
		@@ -65,17 +65,9 @@ static const struct drm_connector_funcs fsl_dcu_drm_connector_funcs = {
		static int fsl_dcu_drm_connector_get_modes(struct drm_connector *connector)
		{
		struct fsl_dcu_drm_connector *fsl_connector;
		int (get_modes)(struct drm_panel panel);
		int num_modes = 0;

		fsl_connector = to_fsl_dcu_connector(connector);
		if (fsl_connector->panel && fsl_connector->panel->funcs &&
		fsl_connector->panel->funcs->get_modes) {
		get_modes = fsl_connector->panel->funcs->get_modes;
		num_modes = get_modes(fsl_connector->panel);
		}

		return num_modes;
		return drm_panel_get_modes(fsl_connector->panel);
		}

		static int fsl_dcu_drm_connector_mode_valid(struct drm_connector *connector,

Admin message