Commit 24b8ff7c authored Mar 22, 2011 by Cesar Eduardo Barros Committed by Linus Torvalds Mar 22, 2011

mm: remove inline from scan_swap_map()



scan_swap_map() is a large function (224 lines), with several loops and a
complex control flow involving several gotos.

Given all that, it is a bit silly that it is marked as inline.  The
compiler agrees with me: on a x86-64 compile, it did not inline the
function.

Remove the "inline" and let the compiler decide instead.

Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
Reviewed-by: Pekka Enberg <penberg@kernel.org>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 40531542

mm/swapfile.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -212,7 +212,7 @@ static int wait_for_discard(void *word)
		#define SWAPFILE_CLUSTER 256
		#define LATENCY_LIMIT 256

		static inline unsigned long scan_swap_map(struct swap_info_struct *si,
		static unsigned long scan_swap_map(struct swap_info_struct *si,
		unsigned char usage)
		{
		unsigned long offset;

Admin message