Commit 24acc689 authored Apr 21, 2010 by Dan Carpenter Committed by David S. Miller Apr 22, 2010

rdma: potential ERR_PTR dereference



In the original code, the "goto out" calls "rdma_destroy_id(cm_id);"
That isn't needed here and would cause problems because "cm_id" is an
ERR_PTR.  The new code just returns directly.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Andy Grover <andy.grover@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 80032cff

net/rds/rdma_transport.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -134,7 +134,7 @@ static int __init rds_rdma_listen_init(void)
		ret = PTR_ERR(cm_id);
		printk(KERN_ERR "RDS/RDMA: failed to setup listener, "
		"rdma_create_id() returned %d\n", ret);
		goto out;
		return ret;
		}

		sin.sin_family = AF_INET,

Admin message