dma-buf: Update kerneldoc for sync_file_create (24a36734) · Commits · 戴 / test

This was missed when adding a dma_fence_get call. While at it also remove the kerneldoc for the static inline helper - no point documenting internals down to every detail. Fixes: ("dma-buf/sync_file: hold reference to fence when creating sync_file") Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk> Cc: Sean Paul <seanpaul@chromium.org> Cc: linux-doc@vger.kernel.org Cc: Jonathan Corbet <corbet@lwn.net> Cc: Sumit Semwal <sumit.semwal@linaro.org> Signed-off-by:

Daniel Vetter <daniel.vetter@intel.com> Reviewed-by:

Gustavo Padovan <gustavo.padovan@collabora.co.uk> Signed-off-by:

Sumit Semwal <sumit.semwal@linaro.org> Link: http://patchwork.freedesktop.org/patch/msgid/20161209185309.1682-3-daniel.vetter@ffwll.ch

drivers/dma-buf/sync_file.c

+4 −10

Original line number	Diff line number	Diff line
		@@ -67,9 +67,10 @@ static void fence_check_cb_func(struct dma_fence f, struct dma_fence_cb cb)
		* sync_file_create() - creates a sync file
		* @fence: fence to add to the sync_fence
		*
		* Creates a sync_file containg @fence. Once this is called, the sync_file
		* takes ownership of @fence. The sync_file can be released with
		* fput(sync_file->file). Returns the sync_file or NULL in case of error.
		* Creates a sync_file containg @fence. This function acquires and additional
		* reference of @fence for the newly-created &sync_file, if it succeeds. The
		* sync_file can be released with fput(sync_file->file). Returns the
		* sync_file or NULL in case of error.
		*/
		struct sync_file sync_file_create(struct dma_fence fence)
		{
		@@ -90,13 +91,6 @@ struct sync_file sync_file_create(struct dma_fence fence)
		}
		EXPORT_SYMBOL(sync_file_create);

		/**
		* sync_file_fdget() - get a sync_file from an fd
		* @fd: fd referencing a fence
		*
		* Ensures @fd references a valid sync_file, increments the refcount of the
		* backing file. Returns the sync_file or NULL in case of error.
		*/
		static struct sync_file *sync_file_fdget(int fd)
		{
		struct file *file = fget(fd);

Admin message