Commit 248f883d authored Jun 25, 2019 by Kenneth Graunke Committed by Jani Nikula Jul 29, 2019

drm/i915: Disable SAMPLER_STATE prefetching on all Gen11 steppings.



The Demand Prefetch workaround (binding table prefetching) only applies
to Icelake A0/B0.  But the Sampler Prefetch workaround needs to be
applied to all Gen11 steppings, according to a programming note in the
SARCHKMD documentation.

Using the Intel Gallium driver, I have seen intermittent failures in
the dEQP-GLES31.functional.copy_image.non_compressed.* tests.  After
applying this workaround, the tests reliably pass.

v2: Remove the overlap with a pre-production w/a

BSpec: 9663
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: stable@vger.kernel.org
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190625090655.19220-1-chris@chris-wilson.co.uk


(cherry picked from commit f9a39387)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>

parent ac65bdfe

drivers/gpu/drm/i915/gt/intel_workarounds.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -1258,7 +1258,11 @@ rcs_engine_wa_init(struct intel_engine_cs engine, struct i915_wa_list wal)
		if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_B0))
		wa_write_or(wal,
		GEN7_SARCHKMD,
		GEN7_DISABLE_DEMAND_PREFETCH \|
		GEN7_DISABLE_DEMAND_PREFETCH);

		/* Wa_1606682166:icl */
		wa_write_or(wal,
		GEN7_SARCHKMD,
		GEN7_DISABLE_SAMPLER_PREFETCH);
		}

Admin message