Commit 2461a8dd authored by Sagi Grimberg's avatar Sagi Grimberg
Browse files

nvme-rdma: Remove duplicate call to nvme_remove_namespaces 



nvme_uninit_ctrl already does that for us. Note that we reordered
nvme_rdma_shutdown_ctrl and nvme_uninit_ctrl, this is perfectly
fine because we actually want ctrl uninit (aen, scan cancellation
and namespaces removal) to happen before we shutdown the rdma
resources.

Also, centralize the deletion work and the dead controller removal
work code duplication into __nvme_rdma_shutdown_ctrl that accepts
a shutdown boolean.

Signed-off-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
parent 57de5a0a

drivers/nvme/host/rdma.c

+10 −7
Original line number Original line Diff line number Diff line
@@ -1660,15 +1660,20 @@ static void nvme_rdma_shutdown_ctrl(struct nvme_rdma_ctrl *ctrl) 
	nvme_rdma_destroy_admin_queue(ctrl);

	nvme_rdma_destroy_admin_queue(ctrl);

}

}





static void __nvme_rdma_remove_ctrl(struct nvme_rdma_ctrl *ctrl, bool shutdown)

{

	nvme_uninit_ctrl(&ctrl->ctrl);

	if (shutdown)

		nvme_rdma_shutdown_ctrl(ctrl);

	nvme_put_ctrl(&ctrl->ctrl);

}



static void nvme_rdma_del_ctrl_work(struct work_struct *work)

static void nvme_rdma_del_ctrl_work(struct work_struct *work)

{

{

	struct nvme_rdma_ctrl *ctrl = container_of(work,

	struct nvme_rdma_ctrl *ctrl = container_of(work,

				struct nvme_rdma_ctrl, delete_work);

				struct nvme_rdma_ctrl, delete_work);





	nvme_remove_namespaces(&ctrl->ctrl);

	__nvme_rdma_remove_ctrl(ctrl, true);

	nvme_rdma_shutdown_ctrl(ctrl);

	nvme_uninit_ctrl(&ctrl->ctrl);

	nvme_put_ctrl(&ctrl->ctrl);

}

}





static int __nvme_rdma_del_ctrl(struct nvme_rdma_ctrl *ctrl)

static int __nvme_rdma_del_ctrl(struct nvme_rdma_ctrl *ctrl)
@@ -1701,9 +1706,7 @@ static void nvme_rdma_remove_ctrl_work(struct work_struct *work) 
	struct nvme_rdma_ctrl *ctrl = container_of(work,

	struct nvme_rdma_ctrl *ctrl = container_of(work,

				struct nvme_rdma_ctrl, delete_work);

				struct nvme_rdma_ctrl, delete_work);





	nvme_remove_namespaces(&ctrl->ctrl);

	__nvme_rdma_remove_ctrl(ctrl, false);

	nvme_uninit_ctrl(&ctrl->ctrl);

	nvme_put_ctrl(&ctrl->ctrl);

}

}





static void nvme_rdma_reset_ctrl_work(struct work_struct *work)

static void nvme_rdma_reset_ctrl_work(struct work_struct *work)

CRA Git | Maintained and supported by SUSTech CRA and CCSE