dma-buf: Remove unused sync_dump() (245e7364) · Commits · 戴 / test

sync_dump() is an unused, unexported, function that adds 64k to the kernel image and doesn't even provide locking around the global array it uses. add/remove: 0/2 grow/shrink: 0/0 up/down: 0/-65734 (-65734) Function old new delta sync_dump 198 - -198 sync_dump_buf 65536 - -65536 Signed-off-by:

Chris Wilson <chris@chris-wilson.co.uk> Cc: Sumit Semwal <sumit.semwal@linaro.org> Cc: Gustavo Padovan <gustavo@padovan.org> Reviewed-by:

Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20190419181904.6199-1-chris@chris-wilson.co.uk

drivers/dma-buf/sync_debug.c

+0 −26

Original line number	Diff line number	Diff line
		@@ -197,29 +197,3 @@ static __init int sync_debugfs_init(void)
		return 0;
		}
		late_initcall(sync_debugfs_init);

		#define DUMP_CHUNK 256
		static char sync_dump_buf[64 * 1024];
		void sync_dump(void)
		{
		struct seq_file s = {
		.buf = sync_dump_buf,
		.size = sizeof(sync_dump_buf) - 1,
		};
		int i;

		sync_info_debugfs_show(&s, NULL);

		for (i = 0; i < s.count; i += DUMP_CHUNK) {
		if ((s.count - i) > DUMP_CHUNK) {
		char c = s.buf[i + DUMP_CHUNK];

		s.buf[i + DUMP_CHUNK] = 0;
		pr_cont("%s", s.buf + i);
		s.buf[i + DUMP_CHUNK] = c;
		} else {
		s.buf[s.count] = 0;
		pr_cont("%s", s.buf + i);
		}
		}
		}

drivers/dma-buf/sync_debug.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -68,6 +68,5 @@ void sync_timeline_debug_add(struct sync_timeline *obj);
		void sync_timeline_debug_remove(struct sync_timeline *obj);
		void sync_file_debug_add(struct sync_file *fence);
		void sync_file_debug_remove(struct sync_file *fence);
		void sync_dump(void);

		#endif /* _LINUX_SYNC_H */

Admin message