vhost/test: stop device before reset (245cdd9f) · Commits · 戴 / test

When device stop was moved out of reset, test device wasn't updated to stop before reset, this resulted in a use after free. Fix by invoking stop appropriately. Fixes: ("vhost: move -net specific code out") Signed-off-by:

Michael S. Tsirkin <mst@redhat.com>

drivers/vhost/test.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -161,6 +161,7 @@ static int vhost_test_release(struct inode inode, struct file f)

		vhost_test_stop(n, &private);
		vhost_test_flush(n);
		vhost_dev_stop(&n->dev);
		vhost_dev_cleanup(&n->dev);
		/* We do an extra flush before freeing memory,
		* since jobs can re-queue themselves. */
		@@ -237,6 +238,7 @@ static long vhost_test_reset_owner(struct vhost_test *n)
		}
		vhost_test_stop(n, &priv);
		vhost_test_flush(n);
		vhost_dev_stop(&n->dev);
		vhost_dev_reset_owner(&n->dev, umem);
		done:
		mutex_unlock(&n->dev.mutex);

Admin message