Commit 244d0128 authored Jul 16, 2020 by Thomas Zimmermann

drm/ast: Initialize DRAM type before posting GPU



Posting the GPU requires the correct DRAM type to be stored in
struct ast_private. Therefore first initialize the DRAM info and
then post the GPU. This restores the original order of instructions
in this function.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Fixes: bad09da6 ("drm/ast: Fixed vram size incorrect issue on POWER")
Cc: Joel Stanley <joel@jms.id.au>
Cc: Y.C. Chen <yc_chen@aspeedtech.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Emil Velikov <emil.l.velikov@gmail.com>
Cc: "Y.C. Chen" <yc_chen@aspeedtech.com>
Cc: <stable@vger.kernel.org> # v4.11+
Link: https://patchwork.freedesktop.org/patch/msgid/20200716125353.31512-6-tzimmermann@suse.de

parent 0149e780

drivers/gpu/drm/ast/ast_main.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -418,15 +418,15 @@ int ast_driver_load(struct drm_device *dev, unsigned long flags)

		ast_detect_chip(dev, &need_post);

		if (need_post)
		ast_post_gpu(dev);

		ret = ast_get_dram_info(dev);
		if (ret)
		goto out_free;
		drm_info(dev, "dram MCLK=%u Mhz type=%d bus_width=%d\n",
		ast->mclk, ast->dram_type, ast->dram_bus_width);

		if (need_post)
		ast_post_gpu(dev);

		ret = ast_mm_init(ast);
		if (ret)
		goto out_free;

Admin message